feat: Datafusion file sink #2155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGS
commented
Jan 30, 2025
AdamGS
commented
Jan 31, 2025
| } | ||
| } | ||
|
|
||
| impl VortexWrite for ObjectStoreWriter { | ||
| async fn write_all<B: IoBuf>(&mut self, buffer: B) -> io::Result<B> { | ||
| self.multipart | ||
| .as_mut() |
There was a problem hiding this comment.
this seems to be problematic with Send, and anyway nothing here was actually used.
a10y
reviewed
Jan 31, 2025
Co-authored-by: Andrew Duffy <[email protected]>
a10y
reviewed
Jan 31, 2025
vortex-io/src/object_store.rs
Outdated
| const CHUNKS_SIZE: usize = 25 * 1024 * 1204; | ||
|
|
||
| for (chunk_idx, chunk) in slice.chunks(25 * 1024 * 1204).enumerate() { | ||
| let payload = Bytes::copy_from_slice(&slice[chunk_idx * CHUNKS_SIZE..][..chunk.len()]); |
There was a problem hiding this comment.
why not use chunk here instead of re-slicing the slice?
There was a problem hiding this comment.
I thought I had a lifetime issue, apparently I don't
AdamGS
force-pushed
the
adamg/datafusion-vortex-write
branch
from
c7c0165 to
9b090a2
Compare
a10y
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This writer is very simple compared to the built-in ones, it doesn't support as many features and generates one file per COPY/INSERT operation.
Closes #2148.