Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(artifacts): Add ArtifactStore to orca #4481

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

xibz
Copy link
Contributor

@xibz xibz commented Jun 29, 2023

This commit adds artifact storage to orca. The new artifact type
remote/base64 is completely compatible with SpEL and users can use the
same SpEL expressions. Meaning that this change should be completely
transparent to users

Signed-off-by: benjamin-j-powell [email protected]

Co-authored-by: Nicolas Favre-Felix [email protected]
Signed-off-by: benjamin-j-powell [email protected]

@dbyron-sf
Copy link
Contributor

LGTM once the kork changes go in.

@xibz xibz force-pushed the artifact-store branch from 9b02a89 to 6f9630a Compare July 6, 2023 15:05
This commit adds artifact storage to orca. The new artifact type
remote/base64 is completely compatible with SpEL and users can use the
same SpEL expressions. Meaning that this change should be completely
transparent to users

Signed-off-by: benjamin-j-powell <[email protected]>

Co-authored-by: Nicolas Favre-Felix <[email protected]>
Signed-off-by: benjamin-j-powell <[email protected]>
@xibz xibz force-pushed the artifact-store branch from 6f9630a to 4cee351 Compare July 6, 2023 15:52
@dbyron-sf dbyron-sf added the ready to merge Approved and ready for merge label Jul 6, 2023
@mergify mergify bot added the auto merged Merged automatically by a bot label Jul 6, 2023
@mergify mergify bot merged commit b23c78b into spinnaker:master Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for merge target-release/1.32
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants