feat(bakery): add includeCRDs in Helm Bake request #4324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new field `includeCRDs` in request to rosco in order to include custom resource definitions manifests in templated output. Signed-off-by: Victor J. Diaz <[email protected]>
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
Am I right that rosco will ignore the additional info if this goes in before spinnaker/rosco#913? |
nemesisOsorio
approved these changes
Nov 7, 2022
|
Yeah, you are right @dbyron-sf. The good thing is in that case Rosco ignores the new parameter and no exception is thrown. |
dbyron-sf
approved these changes
Nov 8, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of spinnaker/spinnaker#6518
Add new field
includeCRDsin request to rosco in order to include custom resource definitions manifests in templated output.