Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dependency): upgrade and pin logback to 1.2.12 #1086

Merged
merged 1 commit into from
Aug 10, 2023
Merged

chore(dependency): upgrade and pin logback to 1.2.12 #1086

merged 1 commit into from
Aug 10, 2023

Conversation

j-sandy
Copy link
Contributor

@j-sandy j-sandy commented Aug 10, 2023

Pinning logback to 1.2.12 till spring boot upgrade to 2.5.15 or above

@j-sandy
chore(dependency): upgrade and pin logback to 1.2.12
6b615d6 
Pinning logback to 1.2.12 till spring boot upgrade to 2.5.15 or above
@j-sandy
Copy link
Contributor Author

j-sandy commented Aug 10, 2023

Consumed the modified kork to build and test all spinnaker components, all build successfully and test passed. Below is the difference in version of logback-core before and after the logback upgrade (in gate):

$ ./gradlew gate-web:dI --dependency logback-core

> Task :gate-web:dependencyInsight
ch.qos.logback:logback-core:1.2.10
  Variant compile:
    | Attribute Name                 | Provided | Requested         |
    |--------------------------------|----------|-------------------|
    | org.gradle.status              | release  |                   |
    | org.gradle.category            | library  | library           |
    | org.gradle.libraryelements     | jar      | classes+resources |
    | org.gradle.usage               | java-api | java-api          |
    | org.gradle.dependency.bundling |          | external          |
    | org.gradle.jvm.environment     |          | standard-jvm      |
    | org.gradle.jvm.version         |          | 11                |
   Selection reasons:
      - By constraint
      - Forced

ch.qos.logback:logback-core:1.2.10
+--- ch.qos.logback:logback-classic:1.2.10
|    +--- io.spinnaker.kork:kork-bom:7.182.1
|    |    \--- compileClasspath
|    \--- org.springframework.boot:spring-boot-starter-logging:2.5.14 (requested ch.qos.logback:logback-classic:1.2.11)
|         +--- io.spinnaker.kork:kork-bom:7.182.1 (*)
|         \--- org.springframework.boot:spring-boot-starter:2.5.14
|              +--- io.spinnaker.kork:kork-bom:7.182.1 (*)
|              +--- org.springframework.boot:spring-boot-starter-web:2.5.14
|              |    +--- io.spinnaker.kork:kork-bom:7.182.1 (*)
|              |    +--- io.spinnaker.kork:kork-web:7.182.1
|              |    |    +--- compileClasspath (requested io.spinnaker.kork:kork-web)
|              |    |    \--- io.spinnaker.kork:kork-bom:7.182.1 (*)
|              |    \--- project :gate-core (requested org.springframework.boot:spring-boot-starter-web)
|              |         \--- compileClasspath
|              +--- org.springframework.boot:spring-boot-starter-webflux:2.5.14
|              |    +--- io.spinnaker.kork:kork-bom:7.182.1 (*)
|              |    \--- io.spinnaker.kork:kork-web:7.182.1 (*)
|              +--- org.springframework.boot:spring-boot-starter-json:2.5.14
|              |    +--- io.spinnaker.kork:kork-bom:7.182.1 (*)
|              |    +--- org.springframework.boot:spring-boot-starter-web:2.5.14 (*)
|              |    \--- org.springframework.boot:spring-boot-starter-webflux:2.5.14 (*)
|              +--- org.springframework.boot:spring-boot-starter-security:2.5.14
|              |    +--- io.spinnaker.kork:kork-bom:7.182.1 (*)
|              |    +--- io.spinnaker.kork:kork-web:7.182.1 (*)
|              |    \--- project :gate-core (requested org.springframework.boot:spring-boot-starter-security) (*)
|              +--- org.springframework.boot:spring-boot-starter-actuator:2.5.14
|              |    +--- compileClasspath (requested org.springframework.boot:spring-boot-starter-actuator)
|              |    +--- io.spinnaker.kork:kork-bom:7.182.1 (*)
|              |    +--- project :gate-core (requested org.springframework.boot:spring-boot-starter-actuator) (*)
|              |    \--- io.spinnaker.kork:kork-core:7.182.1
|              |         +--- compileClasspath (requested io.spinnaker.kork:kork-core)
|              |         +--- io.spinnaker.kork:kork-bom:7.182.1 (*)
|              |         \--- io.spinnaker.kork:kork-web:7.182.1 (*)
|              \--- org.springframework.boot:spring-boot-starter-aop:2.5.14
|                   +--- compileClasspath (requested org.springframework.boot:spring-boot-starter-aop)
|                   +--- io.spinnaker.kork:kork-bom:7.182.1 (*)
|                   \--- io.spinnaker.kork:kork-core:7.182.1 (*)
\--- io.spinnaker.kork:kork-bom:7.182.1 (*)

ch.qos.logback:logback-core:1.2.3 -> 1.2.10
\--- net.logstash.logback:logstash-logback-encoder:4.11
     +--- compileClasspath (requested net.logstash.logback:logstash-logback-encoder)
     \--- io.spinnaker.kork:kork-bom:7.182.1
          \--- compileClasspath

==================After==================

$ ./gradlew gate-web:dI --dependency logback-core

> Task :gate-web:dependencyInsight
ch.qos.logback:logback-core:1.2.12
  Variant compile:
    | Attribute Name                 | Provided | Requested         |
    |--------------------------------|----------|-------------------|
    | org.gradle.status              | release  |                   |
    | org.gradle.category            | library  | library           |
    | org.gradle.libraryelements     | jar      | classes+resources |
    | org.gradle.usage               | java-api | java-api          |
    | org.gradle.dependency.bundling |          | external          |
    | org.gradle.jvm.environment     |          | standard-jvm      |
    | org.gradle.jvm.version         |          | 11                |
   Selection reasons:
      - By constraint
      - Forced

ch.qos.logback:logback-core:1.2.12
+--- ch.qos.logback:logback-classic:1.2.12
|    +--- io.spinnaker.kork:kork-bom:logback-SNAPSHOT
|    |    \--- compileClasspath
|    \--- org.springframework.boot:spring-boot-starter-logging:2.5.14 (requested ch.qos.logback:logback-classic:1.2.11)
|         +--- io.spinnaker.kork:kork-bom:logback-SNAPSHOT (*)
|         \--- org.springframework.boot:spring-boot-starter:2.5.14
|              +--- io.spinnaker.kork:kork-bom:logback-SNAPSHOT (*)
|              +--- org.springframework.boot:spring-boot-starter-web:2.5.14
|              |    +--- io.spinnaker.kork:kork-bom:logback-SNAPSHOT (*)
|              |    +--- io.spinnaker.kork:kork-web:logback-SNAPSHOT
|              |    |    +--- compileClasspath (requested io.spinnaker.kork:kork-web)
|              |    |    \--- io.spinnaker.kork:kork-bom:logback-SNAPSHOT (*)
|              |    \--- project :gate-core (requested org.springframework.boot:spring-boot-starter-web)
|              |         \--- compileClasspath
|              +--- org.springframework.boot:spring-boot-starter-webflux:2.5.14
|              |    +--- io.spinnaker.kork:kork-bom:logback-SNAPSHOT (*)
|              |    \--- io.spinnaker.kork:kork-web:logback-SNAPSHOT (*)
|              +--- org.springframework.boot:spring-boot-starter-json:2.5.14
|              |    +--- io.spinnaker.kork:kork-bom:logback-SNAPSHOT (*)
|              |    +--- org.springframework.boot:spring-boot-starter-web:2.5.14 (*)
|              |    \--- org.springframework.boot:spring-boot-starter-webflux:2.5.14 (*)
|              +--- org.springframework.boot:spring-boot-starter-security:2.5.14
|              |    +--- io.spinnaker.kork:kork-bom:logback-SNAPSHOT (*)
|              |    +--- io.spinnaker.kork:kork-web:logback-SNAPSHOT (*)
|              |    \--- project :gate-core (requested org.springframework.boot:spring-boot-starter-security) (*)
|              +--- org.springframework.boot:spring-boot-starter-actuator:2.5.14
|              |    +--- compileClasspath (requested org.springframework.boot:spring-boot-starter-actuator)
|              |    +--- io.spinnaker.kork:kork-bom:logback-SNAPSHOT (*)
|              |    +--- project :gate-core (requested org.springframework.boot:spring-boot-starter-actuator) (*)
|              |    \--- io.spinnaker.kork:kork-core:logback-SNAPSHOT
|              |         +--- compileClasspath (requested io.spinnaker.kork:kork-core)
|              |         +--- io.spinnaker.kork:kork-bom:logback-SNAPSHOT (*)
|              |         \--- io.spinnaker.kork:kork-web:logback-SNAPSHOT (*)
|              \--- org.springframework.boot:spring-boot-starter-aop:2.5.14
|                   +--- compileClasspath (requested org.springframework.boot:spring-boot-starter-aop)
|                   +--- io.spinnaker.kork:kork-bom:logback-SNAPSHOT (*)
|                   \--- io.spinnaker.kork:kork-core:logback-SNAPSHOT (*)
\--- io.spinnaker.kork:kork-bom:logback-SNAPSHOT (*)

ch.qos.logback:logback-core:1.2.3 -> 1.2.12
\--- net.logstash.logback:logstash-logback-encoder:4.11
     +--- compileClasspath (requested net.logstash.logback:logstash-logback-encoder)
     \--- io.spinnaker.kork:kork-bom:logback-SNAPSHOT
          \--- compileClasspath

@dbyron-sf dbyron-sf added the ready to merge Approved and ready for merge label Aug 10, 2023
@mergify mergify bot added the auto merged label Aug 10, 2023
@mergify mergify bot merged commit ed082ad into master Aug 10, 2023
@j-sandy j-sandy deleted the logback-upgrade branch August 10, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbyron-sf dbyron-sf dbyron-sf approved these changes

Assignees
No one assigned
Labels
auto merged ready to merge Approved and ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-sandy @dbyron-sf