feat(artifacts): Adds ArtifactStore logic to clouddriver #5976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
LGTM once the kork changes go in. |
This commit adds artifact storage to clouddriver. The idea in this commit is artifact will automatically be expanded when the server receives a request since clouddriver is more than likely interested in the artifact. Signed-off-by: benjamin-j-powell <[email protected]>
dbyron-sf
reviewed
Jul 6, 2023
| if (type.equals("embedded/base64")) { | ||
| if (ArtifactTypes.EMBEDDED_BASE64.getMimeType().equals(type)) { | ||
| return fromBase64(artifact); | ||
| } else if (ArtifactTypes.REMOTE_BASE64.getMimeType().equals(type)) { | ||
| return fromBase64(artifact); | ||
| } else { | ||
| throw new NotImplementedException("Embedded type '" + type + "' is not handled."); |
There was a problem hiding this comment.
nit: Maybe it never was, but this isn't necessarily an embedded type, is it?
nemesisOsorio
approved these changes
Jul 6, 2023
dbyron-sf
approved these changes
Jul 6, 2023
dbyron-sf
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds artifact storage to clouddriver. The idea in this
commit is artifact will automatically be expanded when the server
receives a request since clouddriver is more than likely interested in
the artifact.