Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(deprecation): remove deprecated gradle constructs/features from clouddriver in order to upgrade gradle 7 #5950

Merged
merged 2 commits into from
May 19, 2023

Conversation

j-sandy
Copy link
Contributor

@j-sandy j-sandy commented May 15, 2023

While executing the build script with --warning-mode=fail received below error:

Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0

And the deprecated gradle features are:

> Configure project :clouddriver-azure
Using force on a dependency has been deprecated. This is scheduled to be removed in Gradle 7.0. Consider using strict version constraints instead (version { strictly ... } }). Consult the upgrading guide for further information: https://docs.gradle.org/6.8.1/userguide/upgrading_version_5.html#forced_dependencies
        at clouddriver_azure_6ftffoxb07xu7lz9bwdhnw53c$_run_closure1$_closure2.doCall(/clouddriver/clouddriver-azure/clouddriver-azure.gradle:20)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)
> Configure project :clouddriver-yandex
Using force on a dependency has been deprecated. This is scheduled to be removed in Gradle 7.0. Consider using strict version constraints instead (version { strictly ... } }). Consult the upgrading guide for further information: https://docs.gradle.org/6.8.1/userguide/upgrading_version_5.html#forced_dependencies
        at clouddriver_yandex_5ufhkmiao97ey3emk48be2jrk$_run_closure1$_closure2.doCall(/clouddriver/clouddriver-yandex/clouddriver-yandex.gradle:18)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)
> Configure project :clouddriver-google
Using force on a dependency has been deprecated. This is scheduled to be removed in Gradle 7.0. Consider using strict version constraints instead (version { strictly ... } }). Consult the upgrading guide for further information: https://docs.gradle.org/6.8.1/userguide/upgrading_version_5.html#forced_dependencies
        at clouddriver_google_f4jnph9t3vizredbhn83bs760$_run_closure1$_closure2.doCall(/clouddriver/clouddriver-google/clouddriver-google.gradle:18)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)

Tried (version { strictly ... } }) as suggested by guide, but it didn't work. So refactored it with resolutionStrategy.force.

> Configure project :clouddriver-yandex
The compile configuration has been deprecated for dependency declaration. This will fail with an error in Gradle 7.0. Please use the implementation or api configuration instead. Consult the upgrading guide for further information: https://docs.gradle.org/6.8.1/userguide/upgrading_version_5.html#dependencies_should_no_longer_be_declared_using_the_compile_and_runtime_configurations
        at clouddriver_yandex_5ufhkmiao97ey3emk48be2jrk$_run_closure1.doCall(/clouddriver/clouddriver-yandex/clouddriver-yandex.gradle:17)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)

Replaced compile configuration to compileOnly configuration.

@j-sandy j-sandy requested review from plumpy and skandragon as code owners May 15, 2023 08:41
…rom clouddriver in order to upgrade gradle 7

While executing the build script with --warning-mode=fail received below error:
```
Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0
```
And the deprecated gradle features are:
```
> Configure project :clouddriver-azure
Using force on a dependency has been deprecated. This is scheduled to be removed in Gradle 7.0. Consider using strict version constraints instead (version { strictly ... } }). Consult the upgrading guide for further information: https://docs.gradle.org/6.8.1/userguide/upgrading_version_5.html#forced_dependencies
        at clouddriver_azure_6ftffoxb07xu7lz9bwdhnw53c$_run_closure1$_closure2.doCall(/clouddriver/clouddriver-azure/clouddriver-azure.gradle:20)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)
> Configure project :clouddriver-yandex
Using force on a dependency has been deprecated. This is scheduled to be removed in Gradle 7.0. Consider using strict version constraints instead (version { strictly ... } }). Consult the upgrading guide for further information: https://docs.gradle.org/6.8.1/userguide/upgrading_version_5.html#forced_dependencies
        at clouddriver_yandex_5ufhkmiao97ey3emk48be2jrk$_run_closure1$_closure2.doCall(/clouddriver/clouddriver-yandex/clouddriver-yandex.gradle:18)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)
> Configure project :clouddriver-google
Using force on a dependency has been deprecated. This is scheduled to be removed in Gradle 7.0. Consider using strict version constraints instead (version { strictly ... } }). Consult the upgrading guide for further information: https://docs.gradle.org/6.8.1/userguide/upgrading_version_5.html#forced_dependencies
        at clouddriver_google_f4jnph9t3vizredbhn83bs760$_run_closure1$_closure2.doCall(/clouddriver/clouddriver-google/clouddriver-google.gradle:18)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)
```
Tried `(version { strictly ... } })` as suggested by guide, but it didn't work. So refactored it with `resolutionStrategy.force`.

```
> Configure project :clouddriver-yandex
The compile configuration has been deprecated for dependency declaration. This will fail with an error in Gradle 7.0. Please use the implementation or api configuration instead. Consult the upgrading guide for further information: https://docs.gradle.org/6.8.1/userguide/upgrading_version_5.html#dependencies_should_no_longer_be_declared_using_the_compile_and_runtime_configurations
        at clouddriver_yandex_5ufhkmiao97ey3emk48be2jrk$_run_closure1.doCall(/clouddriver/clouddriver-yandex/clouddriver-yandex.gradle:17)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)
```
Replaced `compile` configuration to `compileOnly` configuration.
@j-sandy j-sandy force-pushed the gradle-deprecation-refactor branch from a8318b0 to 641d0ea Compare May 19, 2023 07:48
@dbyron-sf dbyron-sf added the ready to merge Approved and ready for a merge label May 19, 2023
@mergify mergify bot added the auto merged Merged automatically by a bot label May 19, 2023
@mergify mergify bot merged commit 8a1de2f into spinnaker:master May 19, 2023
@j-sandy j-sandy deleted the gradle-deprecation-refactor branch May 22, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for a merge target-release/1.31
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants