fix(aws/test): Flaky test update #5621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was failing whenever the suffix is generated before the second hand turns and the expected string is calculated for a different timestamp. Now the test uses a fixed clock using the instant the test starts.
mattgogerly
approved these changes
Jan 21, 2022
dbyron-sf
approved these changes
Jan 21, 2022
nhtzr
pushed a commit
to armory/clouddriver
that referenced
this pull request
Aug 17, 2022
This test was failing whenever the suffix is generated before the second hand turns and the expected string is calculated for a different timestamp. Now the test uses a fixed clock using the instant the test starts. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
nhtzr
pushed a commit
to armory/clouddriver
that referenced
this pull request
Aug 18, 2022
This test was failing whenever the suffix is generated before the second hand turns and the expected string is calculated for a different timestamp. Now the test uses a fixed clock using the instant the test starts. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
nhtzr
pushed a commit
to armory/clouddriver
that referenced
this pull request
Aug 18, 2022
This test was failing whenever the suffix is generated before the second hand turns and the expected string is calculated for a different timestamp. Now the test uses a fixed clock using the instant the test starts. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was failing whenever the suffix is generated before the second
hand turns and the expected string is calculated for a different
timestamp. Now the test uses a fixed clock using the instant the test
starts.