Skip to content

Commit

Permalink
feat(gce): add support for hyperdisk in GCE (#6288)
Browse files Browse the repository at this point in the history
* feat(gce): add hyperdisk as disktype option

* feat(gce): add testing for hyperdisk disk option

* feat(gce): rewrite test in Java for GoogleDiskTest

* feat(gce): fix spotless violations

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
  • Loading branch information
edgarulg and mergify[bot] authored Oct 4, 2024
1 parent 2300783 commit 32106c5
Show file tree
Hide file tree
Showing 2 changed files with 59 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ package com.netflix.spinnaker.clouddriver.google.model
public enum GoogleDiskType {
PD_STANDARD("pd-standard", true),
PD_SSD("pd-ssd", true),
LOCAL_SSD("local-ssd", false)
LOCAL_SSD("local-ssd", false),
HYPERDISK_BALANCED("hyperdisk-balanced", true)

String text
boolean persistent
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
/*
* Copyright 2024 Harness, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package com.netflix.spinnaker.clouddriver.google.model;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertTrue;

import org.junit.jupiter.api.Test;

public class GoogleDiskTest {

@Test
public void testSettingDiskTypePdSsd() {
GoogleDisk disk = new GoogleDisk();
disk.setType("pd-ssd");

assertEquals(GoogleDiskType.PD_SSD, disk.getType());
}

@Test
public void testSettingDiskTypeHyperdiskBalanced() {
GoogleDisk disk = new GoogleDisk();
disk.setType("hyperdisk-balanced");

assertEquals(GoogleDiskType.HYPERDISK_BALANCED, disk.getType());
}

@Test
public void testDefaultDiskTypeOnUnknown() {
GoogleDisk disk = new GoogleDisk();
disk.setType("UNKNOWN");

assertEquals(GoogleDiskType.PD_STANDARD, disk.getType());
}

@Test
public void testPersistentDiskDetection() {
GoogleDisk disk = new GoogleDisk();
disk.setType("pd-ssd");

assertTrue(disk.isPersistent());
}
}

0 comments on commit 32106c5

Please sign in to comment.