Skip to content

Fix file permissions #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Fix file permissions #139

merged 2 commits into from
Feb 13, 2023

Conversation

mguaypaq
Copy link
Member

@mguaypaq mguaypaq commented Feb 7, 2023

Various data files were incorrectly marked as executable. To correct this, I ran:

$ find derivatives/ -type f -perm /+x -exec chmod -x {} +
$ git commit -a

Afterwards, I checked that all files and directories have uniform permissions:

$ find . -name .git -prune -o -name .github -prune -o -exec stat -c %A {} + | sort -u
drwxr-xr-x
-rw-r--r--

Since I did this in parallel with #138, I'm sure there will be merge conflicts, so I'll mark this as a draft for now.

Various data files were incorrectly marked as executable.
@mguaypaq mguaypaq requested a review from kousu February 7, 2023 19:26
Copy link
Contributor

@kousu kousu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean up work! This looks all good to me. Since this is just changing modes I expect if there are conflicts a git merge will figure them out, so I am happy to pre-approve.

@mguaypaq mguaypaq marked this pull request as ready for review February 13, 2023 20:07
@mguaypaq mguaypaq merged commit 99e366d into master Feb 13, 2023
@mguaypaq mguaypaq deleted the mgp/fix-executable branch February 13, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants