Skip to content

Commit

Permalink
Invoke CI on PR
Browse files Browse the repository at this point in the history
  • Loading branch information
tk0miya committed Mar 14, 2021
1 parent e1fd242 commit d3de7ec
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,4 @@ commands=
extras =
lint
commands=
mypy
mypy sphinxcontrib/

6 comments on commit d3de7ec

@kloczek
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot find how can I submitti some issue ticket So I'll bo that here (sorry).

pytest ob 1.2.4 shows few warnings:

+ PYTHONPATH=/home/tkloczko/rpmbuild/BUILDROOT/python-sphinxcontrib-websupport-1.2.4-4.fc35.x86_64/usr/lib64/python3.8/site-packages:/home/tkloczko/rpmbuild/BUILDROOT/python-sphinxcontrib-websupport-1.2.4-4.fc35.x86_64/usr/lib/python3.8/site-packages
+ /usr/bin/python3 -Bm pytest -ra
=========================================================================== test session starts ============================================================================
platform linux -- Python 3.8.9, pytest-6.2.3, py-1.10.0, pluggy-0.13.1
rootdir: /home/tkloczko/rpmbuild/BUILD/sphinxcontrib-websupport-1.2.4, configfile: setup.cfg
plugins: forked-1.3.0, shutil-1.7.0, virtualenv-1.7.0, asyncio-0.14.0, expect-1.1.0, cov-2.11.1, mock-3.5.1, httpbin-1.0.0, xdist-2.2.1, flake8-1.0.7, timeout-1.4.2, betamax-0.8.1, pyfakefs-4.4.0, freezegun-0.4.2, flaky-3.7.0, cases-3.4.6, hypothesis-6.10.1
collected 13 items

tests/test_searchadapters.py s.                                                                                                                                      [ 15%]
tests/test_websupport.py ...........                                                                                                                                 [100%]

============================================================================= warnings summary =============================================================================
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
  /usr/lib/python3.8/site-packages/alabaster/layout.html:114: DeprecationWarning: 'soft_unicode' has been renamed to 'soft_str'. The old name will be removed in version 2.1.
    _gaq.push(['_setAllowLinker', true]);

tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
  /usr/lib/python3.8/site-packages/alabaster/about.html:70: DeprecationWarning: 'soft_unicode' has been renamed to 'soft_str'. The old name will be removed in version 2.1.

tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
  /usr/lib/python3.8/site-packages/alabaster/about.html:99: DeprecationWarning: 'soft_unicode' has been renamed to 'soft_str'. The old name will be removed in version 2.1.

tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
  /usr/lib/python3.8/site-packages/alabaster/layout.html:215: DeprecationWarning: 'soft_unicode' has been renamed to 'soft_str'. The old name will be removed in version 2.1.

tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
  /usr/lib/python3.8/site-packages/alabaster/layout.html:238: DeprecationWarning: 'soft_unicode' has been renamed to 'soft_str'. The old name will be removed in version 2.1.

tests/test_searchadapters.py::test_whoosh
tests/test_websupport.py::test_build
  <template>:33: DeprecationWarning: 'soft_unicode' has been renamed to 'soft_str'. The old name will be removed in version 2.1.

tests/test_searchadapters.py::test_whoosh
  <template>:224: DeprecationWarning: 'soft_unicode' has been renamed to 'soft_str'. The old name will be removed in version 2.1.

tests/test_searchadapters.py::test_whoosh
  <template>:386: DeprecationWarning: 'soft_unicode' has been renamed to 'soft_str'. The old name will be removed in version 2.1.

tests/test_searchadapters.py::test_whoosh
  <template>:401: DeprecationWarning: 'soft_unicode' has been renamed to 'soft_str'. The old name will be removed in version 2.1.

-- Docs: https://docs.pytest.org/en/stable/warnings.html
========================================================================= short test summary info ==========================================================================
SKIPPED [1] tests/test_searchadapters.py:61: needs xapian bindings installed
================================================================ 12 passed, 1 skipped, 33 warnings in 5.04s ================================================================

@tk0miya
Copy link
Member Author

@tk0miya tk0miya commented on d3de7ec May 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kloczek It seems the warnings is emitted from markupsafe library. Could you upgrade it and retry it?
https://github.com/pallets/markupsafe/blob/master/src/markupsafe/_native.py#L70-L71

@kloczek
Copy link

@kloczek kloczek commented on d3de7ec May 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is pytest with markupsafe 2.0.0rc2:

+ PYTHONPATH=/home/tkloczko/rpmbuild/BUILDROOT/python-sphinxcontrib-websupport-1.2.4-4.fc35.x86_64/usr/lib64/python3.8/site-packages:/home/tkloczko/rpmbuild/BUILDROOT/python-sphinxcontrib-websupport-1.2.4-4.fc35.x86_64/usr/lib/python3.8/site-packages
+ /usr/bin/python3 -Bm pytest -ra
=========================================================================== test session starts ============================================================================
platform linux -- Python 3.8.9, pytest-6.2.3, py-1.10.0, pluggy-0.13.1
rootdir: /home/tkloczko/rpmbuild/BUILD/sphinxcontrib-websupport-1.2.4, configfile: setup.cfg
plugins: forked-1.3.0, shutil-1.7.0, virtualenv-1.7.0, asyncio-0.14.0, expect-1.1.0, cov-2.11.1, mock-3.5.1, httpbin-1.0.0, xdist-2.2.1, flake8-1.0.7, timeout-1.4.2, betamax-0.8.1, pyfakefs-4.4.0, freezegun-0.4.2, flaky-3.7.0, cases-3.4.6, hypothesis-6.10.1, case-1.5.3, isort-1.3.0
collected 13 items

tests/test_searchadapters.py s.                                                                                                                                      [ 15%]
tests/test_websupport.py ...........                                                                                                                                 [100%]

============================================================================= warnings summary =============================================================================
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
  /usr/lib/python3.8/site-packages/alabaster/layout.html:114: DeprecationWarning: 'soft_unicode' has been renamed to 'soft_str'. The old name will be removed in MarkupSafe 2.1.
    _gaq.push(['_setAllowLinker', true]);

tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
  /usr/lib/python3.8/site-packages/alabaster/about.html:70: DeprecationWarning: 'soft_unicode' has been renamed to 'soft_str'. The old name will be removed in MarkupSafe 2.1.

tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
  /usr/lib/python3.8/site-packages/alabaster/about.html:99: DeprecationWarning: 'soft_unicode' has been renamed to 'soft_str'. The old name will be removed in MarkupSafe 2.1.

tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
  /usr/lib/python3.8/site-packages/alabaster/layout.html:215: DeprecationWarning: 'soft_unicode' has been renamed to 'soft_str'. The old name will be removed in MarkupSafe 2.1.

tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
tests/test_searchadapters.py::test_whoosh
  /usr/lib/python3.8/site-packages/alabaster/layout.html:238: DeprecationWarning: 'soft_unicode' has been renamed to 'soft_str'. The old name will be removed in MarkupSafe 2.1.

tests/test_searchadapters.py::test_whoosh
tests/test_websupport.py::test_build
  <template>:33: DeprecationWarning: 'soft_unicode' has been renamed to 'soft_str'. The old name will be removed in MarkupSafe 2.1.

tests/test_searchadapters.py::test_whoosh
  <template>:224: DeprecationWarning: 'soft_unicode' has been renamed to 'soft_str'. The old name will be removed in MarkupSafe 2.1.

tests/test_searchadapters.py::test_whoosh
  <template>:386: DeprecationWarning: 'soft_unicode' has been renamed to 'soft_str'. The old name will be removed in MarkupSafe 2.1.

tests/test_searchadapters.py::test_whoosh
  <template>:401: DeprecationWarning: 'soft_unicode' has been renamed to 'soft_str'. The old name will be removed in MarkupSafe 2.1.

-- Docs: https://docs.pytest.org/en/stable/warnings.html
========================================================================= short test summary info ==========================================================================
SKIPPED [1] tests/test_searchadapters.py:61: needs xapian bindings installed
================================================================ 12 passed, 1 skipped, 33 warnings in 5.23s ================================================================

@tk0miya
Copy link
Member Author

@tk0miya tk0miya commented on d3de7ec May 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kloczek
It seems the warning is raised inside jinja2. And it is also released beta packages. Please check the version of jinja2 also. And please use the 3.0.0rc2 together.

@tk0miya
Copy link
Member Author

@tk0miya tk0miya commented on d3de7ec May 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I found another deprecation warning if I upgrade to jinja2-3.0.0rc2.

  /Users/tkomiya/work/sphinx/sphinx/jinja2glue.py:183: DeprecationWarning: 'contextfunction' is renamed to 'pass_context', the old name will be removed in Jinja 3.1.
    self.environment.globals['debug'] = contextfunction(pformat)

@tk0miya
Copy link
Member Author

@tk0miya tk0miya commented on d3de7ec May 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I posted sphinx-doc/sphinx#9161 (for 4.0.0) and sphinx-doc/sphinx#9162 (for 4.1.0) to sphinx-core.

Please sign in to comment.