Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Sphinx tutorial, part II #9355
New Sphinx tutorial, part II #9355
Changes from 7 commits
1cbaf7f
167828f
dc5dc61
1e49218
2058acc
57b0a1b
e022872
5a057d3
fb23605
6f71c7b
e75f31a
d08c367
3fcaa17
8377a55
0581a17
3571426
e865c52
106346a
a3478eb
5f41044
c9d2a73
15fe52d
013e67f
1383157
d5f452a
74e565f
50bd1c3
f303a4a
6f9bc6e
cb846a3
b9da157
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks PDF production, as
\(\LaTeX\)
mark-up is invalid.\LaTeX
can not be used in math mode.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woops, sorry. Let's continue the conversation in #9475 and #9476
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems we're also noting that themes only apply to HTML docs here implicitly, I wonder if this should be more explicit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should address that in a separate PR, since all the documentation seems to be suggesting that. Every "theme" reference in https://www.sphinx-doc.org/en/master/contents.html is for "HTML" ("HTML Theming", "HTML theme development", "Documentation using a custom theme or integrated in a website"). While writing this response, I tried searching for "sphinx pdf theme", and I got a Stack Overflow answer saying "this can't be done", an unhelpful thread in sphinx-users, and finally a quite new PDF theme that however doesn't even use LaTeX, but weasyprint (¡hola @Nekmo! 👋🏽)
Even if it's possible to have Sphinx themes for things other than HTML, I would like to not point people to things they can't easily find at the moment, without rethinking other parts of the Sphinx documentation first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In any case, I changed the header to say "HTML theme" to make room for other kind of themes in the future 👍🏽