Migrate configs for isort, mypy, and pytest into pyproject.toml #10844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AA-Turner
requested changes
Sep 21, 2022
There was a problem hiding this comment.
Thanks for the PR @cclauss -- looks OK for merge but please revert all the dependency sorting changes -- I see some merit for a later PR but I'd like to keep this just as configuration migration.
Coping also @danieleades for notice on the mypy configuration migration.
A
AA-Turner
approved these changes
Sep 21, 2022
|
Thanks Christian! A |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose
Migrate the configs into
pyproject.tomlusingini2tomlto do the file conversion and runningvalidate-pyprojectto validate the results. Skip any configuration that is not yet PEP 621 compatible.