Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add watchfiles as dependency #152

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

radiac
Copy link
Contributor

@radiac radiac commented Apr 14, 2024

The watchfiles dependency used in server.py is missing from requirements.

Since the changes 5 days ago, with a clean install, you get the following error:

$ sphinx-autobuild
Traceback (most recent call last):
  File "/.../sphinx-autobuild", line 5, in <module>
    from sphinx_autobuild.__main__ import main
  File "/.../sphinx_autobuild/__main__.py", line 22, in <module>
    from sphinx_autobuild.server import RebuildServer
  File "/.../sphinx_autobuild/server.py", line 8, in <module>
    import watchfiles
ModuleNotFoundError: No module named 'watchfiles'

After installing watchfiles the project runs successfully. This PR adds the package as a dependency in pyproject.toml.

The watchfiles dependency used in server.py is missing from requirements
ebrahimebrahim added a commit to brain-microstructure-exploration-tools/abcd-microstructure-pipelines that referenced this pull request Apr 15, 2024
this makes `nox -s docs -- --serve` work

see upcoming fix in sphinx-doc/sphinx-autobuild#152
allemangD pushed a commit to brain-microstructure-exploration-tools/abcd-microstructure-pipelines that referenced this pull request Apr 15, 2024
this makes `nox -s docs -- --serve` work

see upcoming fix in sphinx-doc/sphinx-autobuild#152
@AA-Turner AA-Turner merged commit a3c4959 into sphinx-doc:main Apr 15, 2024
5 checks passed
@hugovk
Copy link
Contributor

hugovk commented Apr 16, 2024

@AA-Turner @pradyunsg Please could we have a bugfix release?

Otherwise we'll need to either pin to the old version or add watchfiles as a temporary dependency to CPython docs (plus backports) and the devguide and PEPs.

Thank you!

@pradyunsg
Copy link
Collaborator

@AA-Turner clicked the relevant buttons and made it happen. :)

@hugovk
Copy link
Contributor

hugovk commented Apr 16, 2024

Confirmed working now, thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants