Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in auto-linking literal block detection #240

Closed
rdzman opened this issue Feb 8, 2024 · 0 comments · Fixed by #241
Closed

bug in auto-linking literal block detection #240

rdzman opened this issue Feb 8, 2024 · 0 comments · Fixed by #241

Comments

@rdzman
Copy link
Contributor

rdzman commented Feb 8, 2024

The code used to avoid auto-linking in literal blocks wrongly assumes that a literal block ends with any blank line. This results in wrongly auto-linking in lines in literal blocks following a blank line.

The correct check is for a non-indented line following a blank line.

rdzman added a commit to rdzman/matlabdomain that referenced this issue Feb 8, 2024
… matlab_auto_link = "all".

The detect_literal_block() method in mat_documenters.py would mistakenly assume that *any* blank line terminates the literal block, rather than looking for a non-indented line *after* a blank line. This resulted in wrongly auto-linking in lines following a blank line in a literal block.

Ref: sphinx-contrib#240
joeced pushed a commit that referenced this issue Feb 10, 2024
…ink = "all". (#241)

The detect_literal_block() method in mat_documenters.py would mistakenly assume that *any* blank line terminates the literal block, rather than looking for a non-indented line *after* a blank line. This resulted in wrongly auto-linking in lines following a blank line in a literal block.

Ref: #240
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant