Fix: Getting the value of a StringToString pflag #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@sagikazarmark could you take a look at this? |
There was a problem hiding this comment.
@terev thanks a lot! I had one comment, but other than that, 👍 !
viper.go
Outdated
| @@ -1177,6 +1181,24 @@ func readAsCSV(val string) ([]string, error) { | |||
| return csvReader.Read() | |||
| } | |||
|
|
|||
| func parseStringToStringFlagValue(val string) map[string]interface{} { | |||
There was a problem hiding this comment.
How about copying the same function from pflag and keeping the implementation as close and possible?
https://github.com/spf13/pflag/blob/master/string_to_string.go#L79
There was a problem hiding this comment.
@sagikazarmark i've made this change. i had to tweak the signature and return types slightly to work with GetStringMap that uses cast.ToStringMap
brainexe
pushed a commit
to brainexe/viper
that referenced
this pull request
Nov 12, 2020
* add parsing for stringToString flags * add logic to return flags default if not val set, add a test * extract parsing into single func * add a few more cases * return nil if unable to parse instead of panicing * return map[string]interface in order to work with cast.ToStringMap * mostly copy pflags implementation of the conversion to a stringtostring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As viper parses pflag values as strings, string to string values weren't being handled correctly . Fixes #608 .