test if flag is a bool before setting inFlag #615
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix to get the following to work
Currently
command
is attached to the boolean flag.According to pflag
https://github.com/spf13/pflag#command-line-flag-syntax
Therefore boolean flags not set inFlag.
There seems to be inconsistencies is c.Flags() earlier on, hence adding the call to merge.
Also I don't understand why
NoOptDefVal
is not set for booleans as is appeared to be automatic by pflag.