Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Viper to 1.8.0 #1420

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Update Viper to 1.8.0 #1420

merged 1 commit into from
Jun 30, 2021

Conversation

sagikazarmark
Copy link
Contributor

@sagikazarmark sagikazarmark commented Jun 16, 2021

Fixes #1406
Fixes #1404
Fixes #1364

Signed-off-by: Mark Sagi-Kazar <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Jun 16, 2021

CLA assistant check
All committers have signed the CLA.

@li0nel
Copy link

li0nel commented Jun 21, 2021

+1 and thanks for opening this PR. Any idea when it will be merged?

@li0nel
Copy link

li0nel commented Jun 27, 2021

Any update?

@li0nel
Copy link

li0nel commented Jun 29, 2021

@umarcor Thanks for approving, do you know when this PR might be merged? I'm in the process of forking but would rather point to the official repo

@umarcor
Copy link
Contributor

umarcor commented Jun 29, 2021

@li0nel, unfortunately, I'm not a maintainer so I can not provide any info apart from the publicly available. Nonetheless, this project is known to prioritise not breaking HEAD consumers before updates/enhancements; I would not wait for this PR to be merged if you are in a rush.

@sagikazarmark
Copy link
Contributor Author

sagikazarmark commented Jun 29, 2021

@li0nel If you need features from Viper, you should be able to use 1.8 in your application.

1.8 also clears the dependency tree for Viper. Would be nice to start percolating that through the ecosystem.

@spf13 spf13 merged commit 701fa6c into spf13:master Jun 30, 2021
@sagikazarmark sagikazarmark deleted the update-viper branch June 30, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants