Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Add support for IJ 2021.3 #988

Closed
wants to merge 4 commits into from
Closed

[2.x] Add support for IJ 2021.3 #988

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f114821
[2.x] Add support for IJ 2021.3
jurriaan Dec 9, 2021
c807bbe
Update build.gradle.kts
raniejade Jan 14, 2022
a604b1b
Use compatible version of org.jetbrains.kotlin
jurriaan Feb 10, 2022
2cd4243
Remove bintray repositories
jurriaan Feb 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/check-pr-idea-plugin.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
build:
strategy:
matrix:
ij_sdk: [IJ193, IJ201, IJ202, IJ203, IJ211, IJ212]
ij_sdk: [IJ193, IJ201, IJ202, IJ203, IJ211, IJ212, IJ213]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ij_sdk: [IJ193, IJ201, IJ202, IJ203, IJ211, IJ212]
ij_sdk: [IJ193, IJ201, IJ202, IJ203, IJ211, IJ212, IJ213]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand Down
11 changes: 9 additions & 2 deletions spek-ide-plugin-intellij-idea/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,16 +41,23 @@ val buildMatrix = mapOf(
ij.VersionRange("211.1", "211.*"),
arrayOf("java", "org.jetbrains.kotlin:211-1.4.21-release-IJ6556.4")
),
"IJ212" to ij.BuildConfig(
"IJ212" to ij.BuildConfig(
"212.4746.92",
"IJ2021.2",
"IJ183",
ij.VersionRange("212.1", "212.*"),
arrayOf("java", "org.jetbrains.kotlin:211-1.4.21-release-IJ6693.43")
),
"IJ213" to ij.BuildConfig(
"213.5744.223",
"IJ2021.3",
"IJ183",
ij.VersionRange("213.1", "213.*"),
arrayOf("java", "org.jetbrains.kotlin:211-1.4.32-release-IJ6693.72")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed this isn't the correct version, looking for the correct version number

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

213-1.6.10-release-923-IJ5744.223 maybe?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

org.jetbrains.kotlin:211-1.4.21-release-IJ6693.43 should still work. Apologies for the delay, I barely have time to work on personal projects nowadays. If you know someone who wants to take over the project, please let me know!

Copy link

@joelhandwell joelhandwell Dec 20, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hhariri @jonnyzzz @mhshams @orangy @lkogler any idea for taking over the project (possibly by JetBrains)?

)
)

val sdkVersion = project.properties["ij.version"] ?: "IJ212"
val sdkVersion = project.properties["ij.version"] ?: "IJ213"
val settings = checkNotNull(buildMatrix[sdkVersion])

intellij {
Expand Down