Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeResolver to ExceptionHandler (OPTION #2) #1326

Closed

Conversation

JKamsker
Copy link

@JKamsker JKamsker commented Sep 30, 2023

Original PR
PR #1
PR #2

This one is the 3rd of 3 PR's. Different flavors for the same problem.
This one is the one, that does not change all too much, but could come with side effects.

Why do i need this? TL;DR when using Logging, for e.g microsoft.extensions.logging, i cannot access the logger without a TypeResolver in order to log the exception details.

  • I have read the Contribution Guidelines (Not available)
  • I have commented on the issue above and discussed the intended changes
  • A maintainer has signed off on the changes and the issue was assigned to me
  • All newly added code is adequately covered by tests
  • All existing tests are still running without errors
  • The documentation was modified to reflect the changes OR no documentation changes are required.

Changes

Add TypeResolver to ExceptionHandler while trying to not break the api.
If the user chose to set the handler directly through the settings, their code might be broken.
But if the user uses SetExceptionHandler, everything is fine, i have made an overload for that.

@FrankRay78
Copy link
Contributor

Superseded by #1411.

@FrankRay78 FrankRay78 closed this Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants