Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package): revert to cli branch #2125

Merged
merged 1 commit into from
Feb 26, 2019
Merged

chore(package): revert to cli branch #2125

merged 1 commit into from
Feb 26, 2019

Conversation

saschanaz
Copy link
Collaborator

As the feature has been reverted in highlight.js.

@marcoscaceres
Copy link
Contributor

We might need to change the way the highlighting code is imported... our build scripts are depending on this feature, so we might need to fix a few other things.

@marcoscaceres
Copy link
Contributor

@saschanaz
Copy link
Collaborator Author

What was the reason to revert it BTW? The error message people reported is that tools/build.js was lacking but AFAIK it hasn't been removed.

@marcoscaceres
Copy link
Contributor

yes, build.js hasn't been removed (reason: I shouldn't be allowed near computers)

@saschanaz
Copy link
Collaborator Author

We might need to change the way the highlighting code is imported... our build scripts are depending on this feature, so we might need to fix a few other things.

Can we merge this first and do it later? Currently we can't even do npm install 🤣

@marcoscaceres
Copy link
Contributor

What I'd like to do is treat hljs like any other library and not do the bundling. So (pseudo code):

import hljs from "highlight.js"
import js from "highlight.js/languages/js"
import xml from "highlight.js/languages/js"
... and so on... 
hljs.registerLanguage(js);
hljs.registerLanguage(xml);
... and so on... 

@saschanaz saschanaz merged commit 50562b0 into develop Feb 26, 2019
@saschanaz saschanaz deleted the saschanaz-patch-1 branch February 26, 2019 14:08
@marcoscaceres
Copy link
Contributor

ok, I'm off to bed. Let's pick this up again tomorrow.

@saschanaz
Copy link
Collaborator Author

Good night!

ThobyV pushed a commit to ThobyV/respec that referenced this pull request Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants