Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hoist Operation from closure to class variable #494

Closed
wants to merge 1 commit into from

Conversation

kislyuk
Copy link
Contributor

@kislyuk kislyuk commented Jul 25, 2017

This makes connexion.Api more extensible by inheritance.

This makes connexion.API more extensible by inheritance
@coveralls
Copy link

coveralls commented Jul 25, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling be2df5b on kislyuk:patch-1 into 78e962f on zalando:master.

@hjacobs
Copy link
Contributor

hjacobs commented Jul 25, 2017

@kislyuk if this should become part of the Connexion API (and people rely on it), could you add a test for this (i.e. overwriting operation_cls)? Thanks!

@jmcs
Copy link
Contributor

jmcs commented Jul 8, 2018

@kislyuk are you still interested in getting this PR merged?

@kislyuk
Copy link
Contributor Author

kislyuk commented Jul 9, 2018

Yes, but I have no bandwidth to add the tests.

@RobbeSneyders
Copy link
Member

Closing since this has been refactored and exposed in #726.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants