Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort routes in RoutingMiddleware #1898

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Sort routes in RoutingMiddleware #1898

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0a4d29
Sort routes in RoutingMiddleware
kosciCZ Mar 18, 2024
93c4a1e
Merge branch 'main' into sort-routes-middleware
RobbeSneyders May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions connexion/middleware/routing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
from connexion.operations import AbstractOperation
from connexion.resolver import Resolver
from connexion.spec import Specification
from connexion.utils import sort_routes

_scope: ContextVar[dict] = ContextVar("SCOPE")

Expand Down Expand Up @@ -129,6 +130,8 @@ def add_api(
next_app=self.app,
**kwargs,
)
# sort routes to make sure that more specific routes are matched first
api.router.routes = sort_routes(api.router.routes, key=lambda r: r.path)

# If an API with the same base_path was already registered, chain the new API as its
# default. This way, if no matching route is found on the first API, the request is
Expand Down
Loading