Figured out at least some way to get function attributes

phpstan/phpstan#12510 (comment)
spaze · Feb 1, 2025 · 98dfdc6 · 98dfdc6
1 parent 9a85b31
commit 98dfdc6
Show file tree

Hide file tree

Showing 3 changed files with 45 additions and 6 deletions.
diff --git a/src/Allowed/Allowed.php b/src/Allowed/Allowed.php
@@ -7,6 +7,8 @@
 use PHPStan\Analyser\Scope;
 use PHPStan\BetterReflection\Reflection\Adapter\FakeReflectionAttribute;
 use PHPStan\BetterReflection\Reflection\Adapter\ReflectionAttribute;
+use PHPStan\BetterReflection\Reflection\ReflectionAttribute as BetterReflectionAttribute;
+use PHPStan\BetterReflection\Reflector\Reflector;
 use PHPStan\Reflection\FunctionReflection;
 use PHPStan\Reflection\MethodReflection;
 use PHPStan\Type\Type;
@@ -22,14 +24,18 @@ class Allowed
 
 	private Formatter $formatter;
 
+	private Reflector $reflector;
+
 	private AllowedPath $allowedPath;
 
 
 	public function __construct(
 		Formatter $formatter,
+		Reflector $reflector,
 		AllowedPath $allowedPath
 	) {
 		$this->formatter = $formatter;
+		$this->reflector = $reflector;
 		$this->allowedPath = $allowedPath;
 	}
 
@@ -162,7 +168,7 @@ private function hasAllowedParamsInAllowed(Scope $scope, ?array $args, Disallowe
 
 
 	/**
-	 * @param list<ReflectionAttribute|FakeReflectionAttribute> $attributes
+	 * @param list<FakeReflectionAttribute|ReflectionAttribute|BetterReflectionAttribute> $attributes
 	 * @param list<string> $allowConfig
 	 * @return bool
 	 */
@@ -216,14 +222,15 @@ private function getAttributes(Scope $scope): array
 
 	/**
 	 * @param Scope $scope
-	 * @return list<FakeReflectionAttribute>|list<ReflectionAttribute>
+	 * @return list<FakeReflectionAttribute|ReflectionAttribute|BetterReflectionAttribute>
 	 */
 	private function getCallAttributes(Scope $scope): array
 	{
-		if ($scope->getFunction() instanceof MethodReflection) {
-			return $scope->isInClass() ? $scope->getClassReflection()->getNativeReflection()->getMethod($scope->getFunction()->getName())->getAttributes() : [];
-		} elseif ($scope->getFunction() instanceof FunctionReflection) {
-			return []; // @todo
+		$function = $scope->getFunction();
+		if ($function instanceof MethodReflection) {
+			return $scope->isInClass() ? $scope->getClassReflection()->getNativeReflection()->getMethod($function->getName())->getAttributes() : [];
+		} elseif ($function instanceof FunctionReflection) {
+			return $this->reflector->reflectFunction($function->getName())->getAttributes();
 		} else {
 			return [];
 		}

diff --git a/tests/Calls/FunctionCallsAllowInClassWithAttributesTest.php b/tests/Calls/FunctionCallsAllowInClassWithAttributesTest.php
@@ -103,6 +103,21 @@ public function testRule(): void
 	}
 
 
+	public function testRuleInFunctions(): void
+	{
+		$this->analyse([__DIR__ . '/../src/AttributeFunctions.php'], [
+			[
+				'Calling strtolower() is forbidden.',
+				15,
+			],
+			[
+				'Calling strtoupper() is forbidden.',
+				16,
+			],
+		]);
+	}
+
+
 	public static function getAdditionalConfigFiles(): array
 	{
 		return [

diff --git a/tests/src/AttributeFunctions.php b/tests/src/AttributeFunctions.php
@@ -0,0 +1,17 @@
+<?php
+declare(strict_types = 1);
+
+#[\Attribute10]
+function withAttribute10(): void
+{
+	strtolower('');
+	strtoupper('');
+}
+
+
+#[\Attribute11]
+function withAttribute11(): void
+{
+	strtolower('');
+	strtoupper('');
+}