Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Individual array delimiter for a single filter #450

Closed
btxtiger opened this issue Mar 17, 2020 · 1 comment
Closed

Individual array delimiter for a single filter #450

btxtiger opened this issue Mar 17, 2020 · 1 comment

Comments

@btxtiger
Copy link
Contributor

Referencing #229

It seems the custom array delimiter is also set for includes, sorts, appends, fields; this creates an insane breaking change for existing projects. It should be possible to override the default limiter , for just a single filter, where filtering for a string with comma is needed.

I just wanted to be able to find this string in my database EL63PB1024Z8/24PB15X3PR0,3.482+999.

AllowedFilter::exact('id', 'ref_id', true, '|'),

PR in progress
@AlexVanderbist
Copy link
Member

Good point! Let's continue this discussion in the PR.

AlexVanderbist pushed a commit that referenced this issue Aug 18, 2020
@btxtiger
Individual array delimiter for a single filter #450 (#451)
47b1a58 
* Gitignore IntelliJ Workspace

* Individual array delimiter for a single filter #450

* Add tests + set delimiter arg as optional #450

* Fix style CI

* Fix style CI

* Fix style CI
@ppisecky ppisecky mentioned this issue Jan 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlexVanderbist @btxtiger