Set model relation on InteractsWithMedia@loadMedia() #3219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very neat, thank you! |
|
I've reverted this as I have a hunch that this change resulted in errors. More info here: #3224 (comment) Should you PR this again, do add a test to see if an media item with an explicitly loaded relation still is serializable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If ever media needs to reference its model (for instance, within a Resource), it will have to make a separate DB query to get the relationship (and this is especially annoying if you disable lazy loading).
When
loadMedia()is called, it will set the model property for all Media within the Collection.