Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some improvements #140

Merged
merged 12 commits into from
Dec 15, 2022
Merged

Some improvements #140

merged 12 commits into from
Dec 15, 2022

Conversation

kudashevs
Copy link
Contributor

@kudashevs kudashevs commented Dec 14, 2022 •
edited
Loading

Hello,

I'd like to propose some improvements:

  • make the constructor finishedAt parameter in the StoredCheckResults class explicitly nullable
  • change the visibility to protected for some fields in the MeiliSearchCheck, PingCheck classes
  • change the visibility to protected for some fields in the ListHealthChecksCommand, RunHealthChecksCommand classes
  • change the visibility to protected for some fields in the HealthCheckResultHistoryItem class
  • change the visibility to protected for some fields in the Health class
  • add skip for Redis-dependent tests when redis extension is not available

I've removed the support for PHP 8.2 from this PR and moved it to #141, just not to mix up things.

@kudashevs
Update run-tests.yml add support for PHP 8.2 version.
253f28d
@kudashevs
Refactor Health change the visibility of the inlineStylesheets field.
9c34486
@kudashevs
Update StoredCheckResults make the finishedAt parameter explicitly nu…
59b4c63 
…llable.
@kudashevs
Refactor HealthCheckResultHistoryItem change the visibility of the gu…
cf47b02 
…arded field.
@kudashevs
Refactor RunHealthChecksCommand change the visibility of some field.
e6fac10
@kudashevs
Refactor ListHealthChecksCommand change the visibility of some field.
af94587
@kudashevs
Refactor PingCheck change the visibility of some field.
896da97
@kudashevs
Refactor MeiliSearchCheck change the visibility of some field.
c487952
@kudashevs
Update RedisCheckTest add test skip when redis is not loaded.
721ee7c
@kudashevs
Update HorizonCheckTest add test skip when redis is not loaded.
b5c1ce8
@kudashevs
Revert run-tests.yml add support for PHP 8.2 version.
6fee9d6 
This reverts commit 253f28d.
@kudashevs kudashevs force-pushed the feature/some_improvements branch from 39a87cc to 6fee9d6 Compare December 14, 2022 18:14
@kudashevs kudashevs mentioned this pull request Dec 14, 2022
Merged
@freekmurze freekmurze merged commit f616b6e into spatie:main Dec 15, 2022
@freekmurze
Copy link
Member

Thanks!

@kudashevs kudashevs deleted the feature/some_improvements branch December 15, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kudashevs @freekmurze