Merge pull request #71 from dominikkukacka/main

Fix allChecksOk and containsFailingCheck behaviour
spatie · Feb 9, 2022 · 7389497 · 7389497
2 parents a0ffad5 + 0629007
commit 7389497
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 4 deletions.
diff --git a/src/ResultStores/StoredCheckResults/StoredCheckResults.php b/src/ResultStores/StoredCheckResults/StoredCheckResults.php
@@ -50,14 +50,14 @@ public function addCheck(StoredCheckResult $line): self
 
     public function allChecksOk(): bool
     {
-        return $this->storedCheckResults->contains(
-            fn (StoredCheckResult $line) => $line->status !== Status::ok()->value
-        );
+        return ! $this->containsFailingCheck();
     }
 
     public function containsFailingCheck(): bool
     {
-        return ! $this->allChecksOk();
+        return $this->storedCheckResults->contains(
+            fn (StoredCheckResult $line) => $line->status !== Status::ok()->value
+        );
     }
 
     /**

diff --git a/tests/ResultStores/StoredCheckResultsTest.php b/tests/ResultStores/StoredCheckResultsTest.php
@@ -20,6 +20,22 @@
     expect($storedCheckResults->containsCheckWithStatus([Status::crashed(), Status::failed()]))->toBeFalse();
 });
 
+it('has a method to check if one or more checks are failing', function () {
+    $storedCheckResults = new StoredCheckResults(new DateTime(), collect([
+        makeStoredCheckResultWithStatus(Status::warning()),
+        makeStoredCheckResultWithStatus(Status::ok()),
+    ]));
+    expect($storedCheckResults->containsFailingCheck())->toBeTrue();
+});
+
+it('has a method to check if all checks are good', function () {
+    $storedCheckResults = new StoredCheckResults(new DateTime(), collect([
+        makeStoredCheckResultWithStatus(Status::ok()),
+        makeStoredCheckResultWithStatus(Status::ok()),
+    ]));
+    expect($storedCheckResults->allChecksOk())->toBeTrue();
+});
+
 function makeStoredCheckResultWithStatus(Status $status): StoredCheckResult
 {
     return StoredCheckResult::make(