Add support for transformation max depths

[rubenvanassche]

No description provided.

[sebastiandedeyne]

Suggested change

	'fail_when_max_transformation_depth_reached' => true,
	'throw_when_max_transformation_depth_reached' => true,

I think throw makes it more clear that there's an exception

[rubenvanassche]

Jup

[sebastiandedeyne]

Suggested change

	use ChecksTransformationDepths;
	use ChecksTransformationDepth;

[sebastiandedeyne]

Not sure this is worth being in a trait

[rubenvanassche]

It needs to be somewhere, also makes it easy for other people who want to build casts based upon max depth checks to include it.

[inmanturbo]

@rubenvanassche
It looks like this broke some packages that depend on laravel-data.

Spatie\LaravelData\Support\Transformation\TransformationContext::__construct(): Argument #11 ($throwWhenMaxDepthReached) must be of type bool, null given

It looks like updating the config to include 'throw_when_max_transformation_depth_reached' => true, will probably fix it at the app level, but I'm not sure how to fix the packages' ci.

Any advice?

[inmanturbo]

for now I'm adding

config()->set('data.throw_when_max_transformation_depth_reached', true);

to getEnvironmentSetUp() in the test case and it seems to work but it feels strange to have to explicitly set the config for a dependency to its default value. These packages don't have any published laravel-data configuration nor do they interact with its config.

[rubenvanassche]

See the answer here: #731