Fix edge case when transforming union collectible type #673
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an edge case where a property may both be
Collection<int, Product>|Collection<int, array>
.Steps for reproduction
This will produce the following error
TypeError: Spatie\LaravelData\Resolvers\TransformedDataCollectableResolver::Spatie\LaravelData\Resolvers{closure}(): Argument #1 ($data) must be of type Spatie\LaravelData\Contracts\BaseData, array given, called in vendor/spatie/laravel-data/src/Resolvers/TransformedDataCollectableResolver.php on line 72
vendor/spatie/laravel-data/src/Resolvers/TransformedDataCollectableResolver.php:108
vendor/spatie/laravel-data/src/Resolvers/TransformedDataCollectableResolver.php:72
vendor/spatie/laravel-data/src/Resolvers/TransformedDataCollectableResolver.php:49
vendor/spatie/laravel-data/src/Resolvers/TransformedDataResolver.php:164
vendor/spatie/laravel-data/src/Resolvers/TransformedDataResolver.php:66
vendor/spatie/laravel-data/src/Resolvers/TransformedDataResolver.php:37
vendor/spatie/laravel-data/src/Concerns/TransformableData.php:35
vendor/spatie/laravel-data/src/Concerns/TransformableData.php:55
Fix
Simply removing the typehint will return the original $data and fix the issue.