Fix issue where non set optional values were transformed

[rust17]

fix: #583 and be compatible with backward which mentioned in #590

[rust17]

@rubenvanassche 😃 I think it's helpful. If you think this change useful too, please consider merging this.

[rubenvanassche]

Good solution, never would have though about that one. Hopefully it will not break performance too hard. Thanks

[xHeaven]

@rubenvanassche Probably just a nitpick, also didn't test it at all so I'm just talking out of my head right now: do we really want to do get_object_vars() inside the foreach loop? Can't we do $objectVars = get_object_vars($data); or something like this outside the loop, and referencing that variable inside the loop? I think it'd help a little if you have massive datasets if we didn't query all the object vars in every iteration from the exact same dataset.

[rust17]

@xHeaven Yes, that sounds more reasonable, moving the get_object_vars() outside of the foreach could potentially improve performance. A pr is on the road.

[rubenvanassche]

That's indeed a good point, did 60 PR's and issues on Friday. Never thought about that 😅

[rubenvanassche]

The only thing is, we now only checking this when a property is optional. If you're not having any Optional properties the call won't be made. Which is maybe an even bigger performance gain? All depends on how many Optional properties you're having. Difficult case ... let's go with the call outside the loop for now though.