Cleanup: eliminate redundant optionalTypesPattern in preg_match_all f…

…or collections
spatie · Jul 3, 2024 · 478c669 · 478c669
1 parent 5741440
commit 478c669
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/src/Support/Annotations/DataIterableAnnotationReader.php b/src/Support/Annotations/DataIterableAnnotationReader.php
@@ -51,7 +51,6 @@ protected function get(
         $kindPattern = '(?:@property|@var|@param)\s*';
         $fqsenPattern = '[\\\\a-z0-9_\|]+';
         $typesPattern = '[\\\\a-z0-9_\\|\\[\\]]+';
-        $optionalTypesPattern = '(?:'.$typesPattern.')*';
         $keyPattern = '(?<key>int|string|int\|string|string\|int|array-key)';
         $parameterPattern = '\s*\$?(?<parameter>[a-z0-9_]+)?';
 
@@ -62,7 +61,7 @@ protected function get(
         );
 
         preg_match_all(
-            "/{$kindPattern}(?<collectionClass>{$fqsenPattern})<(?:{$keyPattern}\s*?,\s*?)?(?<dataClass>{$fqsenPattern})>{$optionalTypesPattern}{$parameterPattern}/i",
+            "/{$kindPattern}(?<collectionClass>{$fqsenPattern})<(?:{$keyPattern}\s*?,\s*?)?(?<dataClass>{$fqsenPattern})>(?:{$typesPattern})*{$parameterPattern}/i",
             $comment,
             $collectionMatches,
         );