Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contrast on text, anchor -> button #179

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

blite
Copy link
Contributor

@blite blite commented Apr 21, 2022

This is to improve the google lighthouse score by default.

Text color was reported as not enough contrast by default which is an accessibility issue.
Button is more appropriate than link and it reports it as non crawl-able.

This is to improve the google lighthouse score by default.

Text color was reported as not enough contrast by default which is an accessibility issue.
Button is more appropriate than link and it reports it as non crawl-able.
@freekmurze freekmurze merged commit e0f1fe0 into spatie:main Apr 22, 2022
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants