Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dutch holidays #67

Merged
merged 8 commits into from
Jan 23, 2024
Merged

Update Dutch holidays #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a2d45a1
Remove "Oudejaarsdag" since it is not an official holiday
ndijkstra Jan 18, 2024
5f78a39
Use correct capitalization of holidays
ndijkstra Jan 18, 2024
1e8625b
Use Eerste and Tweede instead of 1e and 2e
ndijkstra Jan 18, 2024
15a23df
Fix tests
ndijkstra Jan 18, 2024
6719fdf
Merge branch 'main' into main
ndijkstra Jan 19, 2024
98676bb
Update capital letters in snapshot
ndijkstra Jan 19, 2024
8cd96c4
Remove blank line EOF
ndijkstra Jan 19, 2024
18ca186
Update it_can_calculate_dutch_holidays.snap
ndijkstra Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/Countries/Netherlands.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ protected function allHolidays(int $year): array
return array_merge([
'Nieuwjaarsdag' => '01-01',
'Bevrijdingsdag' => '05-05',
'1e Kerstdag' => '12-25',
'2e Kerstdag' => '12-26',
'Eerste kerstdag' => '12-25',
'Tweede kerstdag' => '12-26',
], $this->variableHolidays($year));
}

Expand All @@ -36,11 +36,11 @@ protected function variableHolidays(int $year): array
return [
'Koningsdag' => $koningsDag,
'Goede Vrijdag' => $easter->subDays(2),
'1e Paasdag' => $easter,
'2e Paasdag' => $easter->addDay(),
'Eerste paasdag' => $easter,
'Tweede paasdag' => $easter->addDay(),
'Hemelvaartsdag' => $easter->addDays(39),
'1e Pinksterdag' => $easter->addDays(49),
'2e Pinksterdag' => $easter->addDays(50),
'Eerste pinksterdag' => $easter->addDays(49),
'Tweede pinksterdag' => $easter->addDays(50),
];
}
}
14 changes: 7 additions & 7 deletions tests/.pest/snapshots/Countries/NetherlandsTest/it_can_calculate_dutch_holidays.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@
"date": "2024-03-29"
},
{
"name": "1e Paasdag",
"name": "Eerste paasdag",
"date": "2024-03-31"
},
{
"name": "2e Paasdag",
"name": "Tweede paasdag",
"date": "2024-04-01"
},
{
Expand All @@ -28,19 +28,19 @@
"date": "2024-05-09"
},
{
"name": "1e Pinksterdag",
"name": "Eerste pinksterdag",
"date": "2024-05-19"
},
{
"name": "2e Pinksterdag",
"name": "Tweede pinksterdag",
"date": "2024-05-20"
},
{
"name": "1e Kerstdag",
"name": "Eerste kerstdag",
"date": "2024-12-25"
},
{
"name": "2e Kerstdag",
"name": "Tweede kerstdag",
"date": "2024-12-26"
}
]
]
Loading