Add South African holidays #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Could you rebase on main, so I can run the tests? Also, there seems to be 2 PRs for South Africa. Might be best if you worked together on 1 PR: #32 |
johanmeiring
force-pushed
the
south-africa
branch
from
e23d2de to
09d7f6a
Compare
|
Hi @Nielsvanpach ! I've rebased as requested. As for the other PR... what a coincidence, and implementations seem to be nearly identical. How would you propose we both work on the same PR? Or I suppose you could just merge whichever one ends up being ready first or looks best to you? (I don't mind at all either way) |
johanmeiring
force-pushed
the
south-africa
branch
from
09d7f6a to
5b10761
Compare
|
Yeah! South Africa represented! Nice one @johanmeiring 🎉🎉🎉🎉🎉💪💪💪 |
|
Closing in favour of #30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds South African public holidays, taking into account the law which states that if a public holiday lands on a Sunday then it is also observed the following Monday.