Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public Holidays for Malawi #133

Merged
merged 36 commits into from
Jan 19, 2024
Merged

Public Holidays for Malawi #133

merged 36 commits into from
Jan 19, 2024

Conversation

Crawford30
Copy link
Contributor

@Crawford30 Crawford30 commented Jan 19, 2024 •
edited
Loading

Contributing a new country ?

  • Have you checked to ensure there aren't other open Pull Requests for the same country?
  1. Create a new class in the Countries directory. It should extend the Country class.
  2. Add a test for the new country in the tests directory.
  3. Run the tests so a snapshot gets created.
  4. Verify the result in the newly created snapshot is correct.

Crawford30 and others added 30 commits January 19, 2024 19:41
@Crawford30
Added Uganda holidays and Tests
2cee99c
@Crawford30
Fixed::Name having ' on it
863fb73
@freekmurze @Crawford30
Fix styling
ee2f234
@ricardomartos @Crawford30
Add Venezuela country class and test
ef6911d 
This commit adds the `Venezuela` class to handle holidays in Venezuela. The class includes a method to calculate all fixed holidays and another method to calculate variable holidays based on Easter. Additionally, a test is added to ensure that the calculation of Venezuelan holidays is correct.
@freekmurze @Crawford30
Fix styling
cf9d7bb
@object505 @Crawford30
Add Macedonian holidays
36e83fb
@object505 @Crawford30
Added return type
a81346f
@freekmurze @Crawford30
Fix styling
c777f21
@calonzolg @Crawford30
Adding Nicaragua Holidays
31d6dae 
Avoid PHPStorm insert final newline into snap, failing the test match string.
@calonzolg @Crawford30
fixing return for phpstan
6d282e7
@calonzolg @Crawford30
match utc time
be60114
@kndrckjvr @Crawford30
add philippine's regular holidays
c90301b 
* removed comments
@davsaniuv @Crawford30
Adding Full Mexican Holidays
d2a61f1
@davsaniuv @Crawford30
Add Test
b7bf6ba
@davsaniuv @Crawford30
update test description and remove typo,
c2e0a68
@davsaniuv @Crawford30
remove vscode folder
35129f3
@davsaniuv @Crawford30
Delete .vscode directory
e59e867
@freekmurze @Crawford30
Fix styling
bd3991d
@freekmurze @Crawford30
wip
238519b
@freekmurze @Crawford30
fix test
1f61997
@freekmurze @Crawford30
wip
fa25323
@freekmurze @Crawford30
Fix styling
1f3cb29
@marchanlon @Crawford30
Add support for Irish public holidays (spatie#44)
16b9e70 
* Add support for Irish public holidays

* Add logic that St Brigid's only started from 2023

* Add tests for St Brigid's Day

St Brigids Day is a new holiday in 2023 and it is variable so adding tests around the logic

* Apply PSR12 formatting
@Nielsvanpach @Crawford30
Fix styling
ebad8fb
@Nielsvanpach @Crawford30
use better easter calculation for Ireland
2b79d78
@Nielsvanpach @Crawford30
use correct dates for nicaragua and venezuela
a4f85ee
@Nielsvanpach @Crawford30
cleanup
94a42dc
@Nielsvanpach @Crawford30
move to baseline
8272ab9
@mcbuckets @Crawford30
Add support for Croatian public holidays (spatie#45)
eb5054c 
* adds croatian holidays

* stan fixes

* fixed allHolidays return type
@Nielsvanpach @Crawford30
use easter() instead
af14fa2
Nielsvanpach and others added 6 commits January 19, 2024 19:41
@Nielsvanpach @Crawford30
Fix styling
a799db7
@rats4final @Crawford30
Bolivian holidays (spatie#40)
7c234ee 
* feature: add bolivian holidays

* test: add bolivia test

* test snap

* fixed typo and phpstan

* calculate correct easter date

* Fix styling

---------

Co-authored-by: rats4final <[email protected]>
Co-authored-by: rats4final <[email protected]>
@Nielsvanpach @Crawford30
remove unneeded conversion
bf040bf
@hulkur @Crawford30
Add Estonian holidays (spatie#47)
1cac33f 
* Add Estonian holidays

* Use easter() method for easter date
@Crawford30
Merge branch 'feat/add_uganda_holidays' of https://github.com/Crawfor…
5dddb37 
…d30/holidays into feat/add_uganda_holidays
@Crawford30
Added Malawi's public holidays
95ce250
@Nielsvanpach Nielsvanpach merged commit 5941d7b into spatie:main Jan 19, 2024
8 checks passed
@Nielsvanpach
Copy link
Member

Thanks!

ssmusoke pushed a commit to ssmusoke/holidays that referenced this pull request Jan 20, 2024
@Crawford30 @ssmusoke
Public Holidays for Malawi (spatie#133)
305e858
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.