Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add py-vl-convert-python #42073

Merged
merged 8 commits into from
Jan 29, 2024
Merged

add py-vl-convert-python #42073

merged 8 commits into from
Jan 29, 2024

Conversation

wu-kan
Copy link
Contributor

@wu-kan wu-kan commented Jan 14, 2024

No description provided.

Copy link

spackbot-app bot commented Jan 14, 2024

Hi @wu-kan! I noticed that the following package(s) don't yet have maintainers:

  • py-vl-convert-python

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers("wu-kan")

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame py-vl-convert-python

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

add homepage
Copy link
Member

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to add the dependencies from Cargo.toml to avoid pip downloading things during the install?

@wu-kan wu-kan changed the title add py-vl-convert-python [wip] add py-vl-convert-python Jan 19, 2024
@wu-kan
Copy link
Contributor Author

wu-kan commented Jan 20, 2024

I tried, but failed. And I find other packages also suffer from this (e.g., eza, py-tokenizers). Maybe we need a new download_dependencies phases in spack.build_systems.cargo and spack.build_systems.python_maturin

@wu-kan
Copy link
Contributor Author

wu-kan commented Jan 20, 2024

Do we also need to add the dependencies from Cargo.toml to avoid pip downloading things during the install?

I tried, but failed. And I find other packages also suffer from this (e.g., eza, py-tokenizers). Maybe we need a new download_dependencies phases in spack.build_systems.cargo and spack.build_systems.python_maturin

@wu-kan
Copy link
Contributor Author

wu-kan commented Jan 20, 2024

Just for the py-vl-convert-python package, another solution is using bdists (whl) over sdists (tar.gz).

@wu-kan wu-kan changed the title [wip] add py-vl-convert-python add py-vl-convert-python Jan 20, 2024
@adamjstewart adamjstewart merged commit 6c48eff into spack:develop Jan 29, 2024
13 checks passed
RMeli pushed a commit to RMeli/spack that referenced this pull request Jan 30, 2024
* add py-vl-convert-python

* code format

* Update package.py

add homepage

* Update var/spack/repos/builtin/packages/py-vl-convert-python/package.py

Co-authored-by: Adam J. Stewart <[email protected]>

* remove old versions, add todo

* Update var/spack/repos/builtin/packages/py-vl-convert-python/package.py

Co-authored-by: Adam J. Stewart <[email protected]>

* remove blank line

---------

Co-authored-by: Adam J. Stewart <[email protected]>
@wu-kan wu-kan deleted the package-py-vl-convert-python branch January 31, 2024 08:00
kwryankrattiger pushed a commit to kwryankrattiger/spack that referenced this pull request Jul 9, 2024
* add py-vl-convert-python

* code format

* Update package.py

add homepage

* Update var/spack/repos/builtin/packages/py-vl-convert-python/package.py

Co-authored-by: Adam J. Stewart <[email protected]>

* remove old versions, add todo

* Update var/spack/repos/builtin/packages/py-vl-convert-python/package.py

Co-authored-by: Adam J. Stewart <[email protected]>

* remove blank line

---------

Co-authored-by: Adam J. Stewart <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants