Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a TileFetcher-based constructor for ImageStack #1737

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

ttung
Copy link
Collaborator

@ttung ttung commented Jan 15, 2020

  1. Add a parser from TileFetcher to the TileCollectionData.
  2. Add a top-level classmethod to wrap a TileFetcher and produce an ImageStack.
  3. Add a test to verify this functionality.

Test plan: Tests pass.

Fixes: #1603
Depends on #1736, #1738

@ttung ttung requested a review from shanaxel42 January 15, 2020 21:31
@ttung ttung force-pushed the tonytung-from-tilefetcher branch from 3b592f0 to 0c63716 Compare January 15, 2020 22:21
@codecov-io
Copy link

codecov-io commented Jan 15, 2020

Codecov Report

Merging #1737 into master will increase coverage by 0.02%.
The diff coverage is 92.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1737      +/-   ##
==========================================
+ Coverage   90.07%   90.09%   +0.02%     
==========================================
  Files         248      251       +3     
  Lines        9168     9260      +92     
==========================================
+ Hits         8258     8343      +85     
- Misses        910      917       +7
Impacted Files Coverage Δ
...ish/core/imagestack/parser/tilefetcher/__init__.py 100% <100%> (ø)
...fish/core/imagestack/test/test_from_tilefetcher.py 100% <100%> (ø)
starfish/core/imagestack/imagestack.py 92.83% <87.5%> (-0.13%) ⬇️
...fish/core/imagestack/parser/tilefetcher/_parser.py 90.47% <90.47%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 200c741...a7bfada. Read the comment docs.

@ttung ttung force-pushed the tonytung-from-tilefetcher branch 4 times, most recently from 872135e to a9c1aac Compare January 16, 2020 08:18
@ttung ttung changed the base branch from tonytung-dedup to tonytung-from-tilefetcher-base January 16, 2020 08:19
@ttung ttung force-pushed the tonytung-from-tilefetcher branch from a9c1aac to 0e9d751 Compare January 22, 2020 18:34
@ttung ttung changed the base branch from tonytung-from-tilefetcher-base to tonytung-dedup January 22, 2020 18:36
@ttung ttung force-pushed the tonytung-from-tilefetcher branch 2 times, most recently from 47261ee to f1c4276 Compare January 22, 2020 21:41
@ttung ttung changed the base branch from tonytung-dedup to master January 22, 2020 22:14
1. Add a parser from TileFetcher to the TileCollectionData.
2. Add a top-level classmethod to wrap a TileFetcher and produce an ImageStack.
3. Add a test to verify this functionality.

Test plan: Tests pass.

Fixes: #1603
@ttung ttung force-pushed the tonytung-from-tilefetcher branch from f1c4276 to a7bfada Compare January 22, 2020 22:15
@ttung ttung merged commit 0106f03 into master Jan 23, 2020
@ttung ttung deleted the tonytung-from-tilefetcher branch January 23, 2020 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose TileFetcher api to users to provide them the ability to write a loader for their file formats
3 participants