[easy] Document workaround for python3.8 #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I dug into it a bit more and the issue is that installing scikit-image from source requires numpy to already be installed. Typically, scikit-image is installed from prebuilt binaries, which circumvents the issue. However, scikit-image has not declared itself fully compatible with python3.8, and as such, is not producing prebuilt binaries.
Codecov Report
@@ Coverage Diff @@
## master #1705 +/- ##
=======================================
Coverage 89.89% 89.89%
=======================================
Files 246 246
Lines 9177 9177
=======================================
Hits 8250 8250
Misses 927 927Continue to review full report at Codecov.
|
neuromusic
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I dug into it a bit more and the issue is that installing scikit-image from source requires numpy to already be installed. Typically, scikit-image is installed from prebuilt binaries, which circumvents the issue. However, scikit-image has not declared itself fully compatible with python3.8, and as such, is not producing prebuilt binaries.