Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test hooks without requiring jwst #199

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Oct 14, 2024

The current test_hooks file is skipped if jwst is not installed:

pytest.importorskip("jwst")

This PR removes the importorskip and tests the hooks without requiring jwst is installed.

As this is a tests only change no regression tests were run and no changelog was added.

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run regression tests with this branch installed ("git+https://github.com/<fork>/stpipe@<branch>")
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@braingram braingram added the no-changelog-entry-needed does not require an entry in `CHANGES.rst` label Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 87.75510% with 6 lines in your changes missing coverage. Please review.

Project coverage is 94.62%. Comparing base (c55d0d2) to head (1e50496).
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
tests/test_hooks.py 86.66% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #199       +/-   ##
===========================================
+ Coverage   75.26%   94.62%   +19.35%     
===========================================
  Files          34       37        +3     
  Lines        2689     3126      +437     
===========================================
+ Hits         2024     2958      +934     
+ Misses        665      168      -497     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram force-pushed the no_jwst_hooks branch 2 times, most recently from aed7aa4 to 1b22347 Compare October 14, 2024 13:36
@braingram braingram marked this pull request as ready for review October 14, 2024 18:37
@braingram braingram requested a review from a team as a code owner October 14, 2024 18:37
@braingram braingram merged commit 03aa64f into spacetelescope:main Oct 14, 2024
18 checks passed
@braingram braingram deleted the no_jwst_hooks branch October 14, 2024 18:52
@braingram braingram mentioned this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed does not require an entry in `CHANGES.rst`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants