Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCSB-145] require Python 3.10 #149

Merged
merged 4 commits into from
Mar 20, 2024
Merged

Conversation

zacharyburnett
Copy link
Collaborator

resolves SCSB-145

propagate Astropy's deprecation of Python 3.9 to downstream packages

Note

this PR was generated automatically by batchpr 🤖

@zacharyburnett zacharyburnett requested a review from a team as a code owner March 14, 2024 18:12
@zacharyburnett zacharyburnett self-assigned this Mar 14, 2024
@zacharyburnett zacharyburnett added the no-changelog-entry-needed does not require an entry in `CHANGES.rst` label Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 58.95%. Comparing base (e747142) to head (484c45d).
Report is 2 commits behind head on main.

Files Patch % Lines
src/stpipe/step.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
- Coverage   59.33%   58.95%   -0.38%     
==========================================
  Files          24       24              
  Lines        1618     1652      +34     
==========================================
+ Hits          960      974      +14     
- Misses        658      678      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacharyburnett zacharyburnett marked this pull request as draft March 14, 2024 18:32
@zacharyburnett zacharyburnett marked this pull request as ready for review March 15, 2024 19:37
Copy link
Collaborator

@tapastro tapastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might as well try to get this merged before we make a release for jwst b10.2. Just some changes requested on lint/black/? removing useful comments.

@zacharyburnett
Copy link
Collaborator Author

I think we might as well try to get this merged before we make a release for jwst b10.2. Just some changes requested on lint/black/? removing useful comments.

no problem, fixed in 08eb649; I'll fix the script so it preserves comments in the future

Copy link
Collaborator

@tapastro tapastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@tapastro tapastro merged commit 98b9e59 into spacetelescope:main Mar 20, 2024
15 of 17 checks passed
@zacharyburnett zacharyburnett deleted the scsb145 branch March 21, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed does not require an entry in `CHANGES.rst`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants