Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3890: One missing enum value for DHS subarray #428

Merged
merged 3 commits into from
Mar 6, 2025

Conversation

tapastro
Copy link
Collaborator

@tapastro tapastro commented Mar 6, 2025

Resolves JP-3890
Matches work in JWSTKD-566

This PR addresses a subarray value missed in updates for JP-3890.

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run jwst regression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@tapastro tapastro requested a review from a team as a code owner March 6, 2025 16:08
@braingram
Copy link
Collaborator

Does this also need to go into subarray.schema and p_subarray.schema?

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.35%. Comparing base (088e8a6) to head (2954391).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #428   +/-   ##
=======================================
  Coverage   78.35%   78.35%           
=======================================
  Files         109      109           
  Lines        5129     5129           
=======================================
  Hits         4019     4019           
  Misses       1110     1110           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tapastro tapastro enabled auto-merge March 6, 2025 16:34
@tapastro tapastro merged commit 9bd551d into spacetelescope:main Mar 6, 2025
19 checks passed
@tapastro tapastro deleted the jp-3890-missing branch March 6, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants