Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug preventing NirspecQuadFlatModel instantiation from NirspecFlatModel #401

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

emolter
Copy link
Contributor

@emolter emolter commented Feb 12, 2025

Closes #186

This PR fixes a bug where attempting to initialize a NirspecQuadFlatModel from a NirspecFlatModel would raise TypeError: dynamic_mask() missing 1 required positional argument: 'mnemonic_map'.

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run jwst regression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@emolter
Copy link
Contributor Author

emolter commented Feb 12, 2025

regression tests started here https://github.com/spacetelescope/RegressionTests/actions/runs/13293800994

edit: failures are unrelated. They match the expected failures from merging the resample changes in jwst: https://github.com/spacetelescope/RegressionTests/actions/runs/13292323770

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.41%. Comparing base (4e83608) to head (455c881).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #401      +/-   ##
==========================================
+ Coverage   78.16%   78.41%   +0.24%     
==========================================
  Files         115      115              
  Lines        5144     5152       +8     
==========================================
+ Hits         4021     4040      +19     
+ Misses       1123     1112      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emolter emolter marked this pull request as ready for review February 12, 2025 21:34
@emolter emolter requested a review from a team as a code owner February 12, 2025 21:34
@emolter emolter requested a review from braingram February 12, 2025 21:35
Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@emolter emolter enabled auto-merge (squash) February 12, 2025 22:16
@emolter emolter merged commit dd86d11 into spacetelescope:main Feb 12, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NirspecQuadFlatModel.__init__ fails when provided a NirspecFlatModel
2 participants