-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
increase asdf version, switch _force_raw_types for load_yaml #288
increase asdf version, switch _force_raw_types for load_yaml #288
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #288 +/- ##
==========================================
+ Coverage 64.84% 64.95% +0.11%
==========================================
Files 103 104 +1
Lines 5694 5712 +18
==========================================
+ Hits 3692 3710 +18
Misses 2002 2002 ☔ View full report in Codecov by Sentry. |
0c0cc5e
to
519a2a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve the minimum asdf bump - but I don't quite follow the change from _force_raw_types to load_yaml. Does this address a bug, improve performance, prep for a deprecation, or something else entirely?
Thanks for taking a look. I should have added more details. asdf-format/asdf#1700 introduced |
519a2a5
to
cb90cdd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, appreciate the clarification! Sorry for the accidental re-request, @zacharyburnett - misclick 😬
Increases minimum asdf version to 3.1.0 (inline with jwst: https://github.com/spacetelescope/jwst/blob/master/pyproject.toml#L22) and switches
_force_raw_types
usage toload_tree
.Also updates one test that fails with ASDF standard 1.6.0 as the default due to an incorrect assumption about the tag version:
stdatamodels/src/stdatamodels/jwst/transforms/converters/tests/test_models.py
Lines 76 to 77 in 50751a8
assumes the tag will be
1.0.0
. With ASDF standard 1.6.0 the tag will be1.1.0
:stdatamodels/src/stdatamodels/jwst/transforms/resources/manifests/jwst_transforms-1.1.0.yaml
Lines 46 to 47 in 50751a8
Checklist
CHANGES.rst
(either inBug Fixes
orChanges to API
)