map JWST to OIFITS keywords prior to validate #234
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @rcooper295 using
AmiOIModel.update
results in aValidationError
. This is due to the mapping of JWST to OIFITS keywords only duringAmiOIModel.on_save
(which is not called duringupdate
).This PR updates
AmiOIModel
to map JWST to OIFITS keywords before callingvalidate
(which is called duringupdate
and also fixes an issue that without this PRAmiOIModel.validate
would also similarly fail).Unit tests were added to verify that
AmiOIModel.update
andAmiOIModel.validate
run successfully for an OIFITS compliant model.Regression tests run with no errors: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1047/
Checklist
CHANGES.rst
(either inBug Fixes
orChanges to API
)