Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3726: Resource Warnings when Using Multiprocessing #350

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kmacdonald-stsci
Copy link
Collaborator

@kmacdonald-stsci kmacdonald-stsci commented Mar 7, 2025

Resolves JP-3726

This PR addresses when running the detector 1 pipeline, "No space left on device" and "warnings.warn('resource_tracker: There appear to be %d '" warnings appeared. On @melanieclarke's recommendation, I switched the multiprocessing from "forkserver" to "spawn" and those warnings disappeared.

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run regression tests with this branch installed ("git+https://github.com/<fork>/stcal@<branch>")
news fragment change types...
  • changes/<PR#>.apichange.rst: change to public API
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.96%. Comparing base (068afd9) to head (0c329fd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #350   +/-   ##
=======================================
  Coverage   85.96%   85.96%           
=======================================
  Files          61       61           
  Lines       10333    10333           
=======================================
  Hits         8883     8883           
  Misses       1450     1450           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. In my local testing, this worked for me to avoid the resource warnings. The "spawn" method might be slightly slower, but not by a lot.

I think this just needs a change note and regtest runs.

@kmacdonald-stsci
Copy link
Collaborator Author

Changes look good. In my local testing, this worked for me to avoid the resource warnings. The "spawn" method might be slightly slower, but not by a lot.

I think this just needs a change note and regtest runs.

I added a change fragment and kicked off a regression test here:

https://github.com/spacetelescope/RegressionTests/actions/runs/13726398697

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants