Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove schema_editor #8909

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Oct 22, 2024

This PR removes schema_editor including:

  • removing the schema_editor installed script
  • removing the availability of the schema_editor submodule via jwst.datamodels
  • removes the schema_editor regression tests

This script was used for comparing keyword dictionary and datamodel schema fits keyword definitions. It will be replaced by the private kwtool in stdatamodels: spacetelescope/stdatamodels#337

Once merged
https://innerspace.stsci.edu/pages/viewpage.action?spaceKey=SCSB&title=Keyword+Dictionary+JSON+vs.+YAML+Comparison+Process
can be updated to reflect the new process.
A follow-up PR will remove schema_editor from stdatamodels: spacetelescope/stdatamodels#352

Regression tests: https://github.com/spacetelescope/RegressionTests/actions/runs/11618412360
show 1 unrelated failure (same as main) and 1 due to an artifactory hiccup which resulted in the failure to download a file (likely due to the network issues today)

I'd say this removes schema_editor so this PR
Closes https://jira.stsci.edu/browse/JP-2131
Closes https://jira.stsci.edu/browse/JP-3783
Closes https://jira.stsci.edu/browse/AL-798
Closes https://jira.stsci.edu/browse/JP-2383

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. Build 11.3 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly
news fragment change types...
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change
  • changes/<PR#>.docs.rst
  • changes/<PR#>.stpipe.rst
  • changes/<PR#>.datamodels.rst
  • changes/<PR#>.scripts.rst
  • changes/<PR#>.fits_generator.rst
  • changes/<PR#>.set_telescope_pointing.rst
  • changes/<PR#>.pipeline.rst

stage 1

  • changes/<PR#>.group_scale.rst
  • changes/<PR#>.dq_init.rst
  • changes/<PR#>.emicorr.rst
  • changes/<PR#>.saturation.rst
  • changes/<PR#>.ipc.rst
  • changes/<PR#>.firstframe.rst
  • changes/<PR#>.lastframe.rst
  • changes/<PR#>.reset.rst
  • changes/<PR#>.superbias.rst
  • changes/<PR#>.refpix.rst
  • changes/<PR#>.linearity.rst
  • changes/<PR#>.rscd.rst
  • changes/<PR#>.persistence.rst
  • changes/<PR#>.dark_current.rst
  • changes/<PR#>.charge_migration.rst
  • changes/<PR#>.jump.rst
  • changes/<PR#>.clean_flicker_noise.rst
  • changes/<PR#>.ramp_fitting.rst
  • changes/<PR#>.gain_scale.rst

stage 2

  • changes/<PR#>.assign_wcs.rst
  • changes/<PR#>.badpix_selfcal.rst
  • changes/<PR#>.msaflagopen.rst
  • changes/<PR#>.nsclean.rst
  • changes/<PR#>.imprint.rst
  • changes/<PR#>.background.rst
  • changes/<PR#>.extract_2d.rst
  • changes/<PR#>.master_background.rst
  • changes/<PR#>.wavecorr.rst
  • changes/<PR#>.srctype.rst
  • changes/<PR#>.straylight.rst
  • changes/<PR#>.wfss_contam.rst
  • changes/<PR#>.flatfield.rst
  • changes/<PR#>.fringe.rst
  • changes/<PR#>.pathloss.rst
  • changes/<PR#>.barshadow.rst
  • changes/<PR#>.photom.rst
  • changes/<PR#>.pixel_replace.rst
  • changes/<PR#>.resample_spec.rst
  • changes/<PR#>.residual_fringe.rst
  • changes/<PR#>.cube_build.rst
  • changes/<PR#>.extract_1d.rst
  • changes/<PR#>.resample.rst

stage 3

  • changes/<PR#>.assign_mtwcs.rst
  • changes/<PR#>.mrs_imatch.rst
  • changes/<PR#>.tweakreg.rst
  • changes/<PR#>.skymatch.rst
  • changes/<PR#>.exp_to_source.rst
  • changes/<PR#>.outlier_detection.rst
  • changes/<PR#>.tso_photometry.rst
  • changes/<PR#>.stack_refs.rst
  • changes/<PR#>.align_refs.rst
  • changes/<PR#>.klip.rst
  • changes/<PR#>.spectral_leak.rst
  • changes/<PR#>.source_catalog.rst
  • changes/<PR#>.combine_1d.rst
  • changes/<PR#>.ami.rst

other

  • changes/<PR#>.wfs_combine.rst
  • changes/<PR#>.white_light.rst
  • changes/<PR#>.cube_skymatch.rst
  • changes/<PR#>.engdb_tools.rst
  • changes/<PR#>.guider_cds.rst

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.68%. Comparing base (fa9d957) to head (1f87cb2).
Report is 434 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8909      +/-   ##
==========================================
- Coverage   64.51%   63.68%   -0.84%     
==========================================
  Files         376      375       -1     
  Lines       38733    38689      -44     
==========================================
- Hits        24990    24638     -352     
- Misses      13743    14051     +308     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram force-pushed the remove_schema_editor branch from b41b2d4 to bfb5689 Compare October 30, 2024 20:18
Comment on lines -20 to -22
KEYWORD_DB = 'datamodels/keyword_db'
FIXED_SCHEMA = 'fixed'
SCHEMA_TRUTH = 'truth/test_schema_editor'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once merged these artifactory directories could be removed. The copy of the keyword dictionary looks to be from 2020.

@braingram braingram marked this pull request as ready for review October 30, 2024 20:21
@braingram braingram requested a review from a team as a code owner October 30, 2024 20:21
@braingram braingram requested a review from tapastro October 30, 2024 20:21
@braingram braingram force-pushed the remove_schema_editor branch from bfb5689 to 1f87cb2 Compare October 31, 2024 19:15
Copy link
Contributor

@tapastro tapastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@braingram braingram merged commit a32f8b0 into spacetelescope:main Nov 1, 2024
31 checks passed
@braingram braingram deleted the remove_schema_editor branch November 1, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants