-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove multiline logger #8781
Remove multiline logger #8781
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Regression tests started here: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8781 +/- ##
==========================================
- Coverage 60.76% 60.75% -0.02%
==========================================
Files 375 375
Lines 38382 38367 -15
==========================================
- Hits 23323 23308 -15
Misses 15059 15059 ☔ View full report in Codecov by Sentry. |
Report generation failed for the tests I ran on GA, also the current truth files need the nightly requirements, not the last released. Running again on Jenkins: |
Regtest changes are all due to #8759, which was in the middle of being okified when I ran tests. I will merge when CI is complete. |
Closes #6407
This PR is a second attempt to resolve issue #6407 by removing the MultiLineLogger, based on PR #8694.
All log messages containing newlines have been removed, so this default should no longer be needed. Removing it should resolve some technical debt.
Tasks
Build 11.3
(use the latest build if not sure)CHANGES.rst
within the relevant release section (otherwise add theno-changelog-entry-needed
label to this PR)docs/
pageokify_regtests
to update the truth files