Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove multiline logger #8781

Merged

Conversation

melanieclarke
Copy link
Collaborator

@melanieclarke melanieclarke commented Sep 12, 2024

Closes #6407

This PR is a second attempt to resolve issue #6407 by removing the MultiLineLogger, based on PR #8694.

All log messages containing newlines have been removed, so this default should no longer be needed. Removing it should resolve some technical debt.

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. Build 11.3 (use the latest build if not sure)
  • Does this PR change user-facing code / API?
    • add an entry to CHANGES.rst within the relevant release section (otherwise add the no-changelog-entry-needed label to this PR)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@melanieclarke melanieclarke added this to the Build 11.1 milestone Sep 12, 2024
Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@melanieclarke
Copy link
Collaborator Author

melanieclarke commented Sep 12, 2024

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.75%. Comparing base (418d9a8) to head (9f82b52).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8781      +/-   ##
==========================================
- Coverage   60.76%   60.75%   -0.02%     
==========================================
  Files         375      375              
  Lines       38382    38367      -15     
==========================================
- Hits        23323    23308      -15     
  Misses      15059    15059              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@melanieclarke
Copy link
Collaborator Author

Report generation failed for the tests I ran on GA, also the current truth files need the nightly requirements, not the last released. Running again on Jenkins:
https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1711/

@melanieclarke melanieclarke marked this pull request as ready for review September 13, 2024 16:48
@melanieclarke melanieclarke requested a review from a team as a code owner September 13, 2024 16:48
@melanieclarke
Copy link
Collaborator Author

Regtest changes are all due to #8759, which was in the middle of being okified when I ran tests.

I will merge when CI is complete.

@melanieclarke melanieclarke merged commit 411d4d8 into spacetelescope:master Sep 13, 2024
29 checks passed
@melanieclarke melanieclarke deleted the remove_multiline_logger branch September 13, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log raises TypeError when matplotlib usetex=True
2 participants