Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3729: log version and crds context at end of step/pipeline runs #8760

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Sep 6, 2024

This PR adds log messages (info level) for the jwst version and crds context at the end of pipeline/step runs (by making logging calls during finalize_result). The crds context was previously logged only if reference files were used and is now logged for every run. An example of the log messages is as follows:

2024-09-06 13:13:55,491 - stpipe.Image3Pipeline - INFO - Results used CRDS context: jwst_1276.pmap
2024-09-06 13:13:55,491 - stpipe.Image3Pipeline - INFO - Results used jwst version: 1.14.1.dev350+g8efc26fdb
2024-09-06 13:13:55,491 - stpipe.Image3Pipeline - INFO - Step Image3Pipeline done

Resolves JP-3729

Closes #8749

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • All comments are resolved
  • Make sure the JIRA ticket is resolved properly

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.83%. Comparing base (d4c2f1b) to head (e16c058).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8760   +/-   ##
=======================================
  Coverage   60.83%   60.83%           
=======================================
  Files         373      373           
  Lines       38636    38636           
=======================================
  Hits        23503    23503           
  Misses      15133    15133           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram marked this pull request as ready for review September 6, 2024 17:24
@braingram braingram requested a review from a team as a code owner September 6, 2024 17:24
@braingram braingram requested a review from drlaw1558 September 6, 2024 17:25
Copy link
Collaborator

@drlaw1558 drlaw1558 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M in general; I can now see both the CRDS and cal pipeline version in det1, spec2, and spec3 logs.

The jwst version printed looks unexpected though. Testing this PR I get 1.14.1.dev396+gf252448ee which seems unexpected since development has moved on past 1.15.1

Indeed, even using a standalone environment with jwst 1.15.1 installed, I till get 1.14.1.dev396+gf252448ee reported by the 1.15.1 environment call to jwst.version

Are there some unresolved issues with the version call?

@braingram
Copy link
Collaborator Author

LG2M in general; I can now see both the CRDS and cal pipeline version in det1, spec2, and spec3 logs.

The jwst version printed looks unexpected though. Testing this PR I get 1.14.1.dev396+gf252448ee which seems unexpected since development has moved on past 1.15.1

Indeed, even using a standalone environment with jwst 1.15.1 installed, I till get 1.14.1.dev396+gf252448ee reported by the 1.15.1 environment call to jwst.version

Are there some unresolved issues with the version call?

Thanks for giving this a test. The version was 1.14.1.etc due to the out-of-date tags. I just pushed the updated tags (from the spacetelescope upstream) to my fork. Any local testing will also require pulling new tags to get an updated version (as the version is dynamically set from the git tag).

@braingram
Copy link
Collaborator Author

braingram commented Sep 7, 2024

@braingram braingram merged commit fad3ee0 into spacetelescope:master Sep 9, 2024
29 checks passed
@braingram braingram deleted the log_version branch September 9, 2024 13:31
@braingram braingram restored the log_version branch September 10, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report jwst software version in output log
3 participants