-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3729: log version and crds context at end of step/pipeline runs #8760
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8760 +/- ##
=======================================
Coverage 60.83% 60.83%
=======================================
Files 373 373
Lines 38636 38636
=======================================
Hits 23503 23503
Misses 15133 15133 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG2M in general; I can now see both the CRDS and cal pipeline version in det1, spec2, and spec3 logs.
The jwst version printed looks unexpected though. Testing this PR I get 1.14.1.dev396+gf252448ee which seems unexpected since development has moved on past 1.15.1
Indeed, even using a standalone environment with jwst 1.15.1 installed, I till get 1.14.1.dev396+gf252448ee reported by the 1.15.1 environment call to jwst.version
Are there some unresolved issues with the version call?
Thanks for giving this a test. The version was 1.14.1.etc due to the out-of-date tags. I just pushed the updated tags (from the spacetelescope upstream) to my fork. Any local testing will also require pulling new tags to get an updated version (as the version is dynamically set from the git tag). |
f252448
to
d426b97
Compare
d426b97
to
e16c058
Compare
Regression tests: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1693/ |
This PR adds log messages (info level) for the jwst version and crds context at the end of pipeline/step runs (by making logging calls during
finalize_result
). The crds context was previously logged only if reference files were used and is now logged for every run. An example of the log messages is as follows:Resolves JP-3729
Closes #8749
Checklist for PR authors (skip items if you don't have permissions or they are not applicable)
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR