Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3731: Update association path warning message. #8752

Merged
merged 7 commits into from
Sep 10, 2024

Conversation

drlaw1558
Copy link
Collaborator

@drlaw1558 drlaw1558 commented Sep 4, 2024

This PR addresses JP-3731, updating the log message warning about use of paths within association files.

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • All comments are resolved
  • Make sure the JIRA ticket is resolved properly

@drlaw1558 drlaw1558 requested a review from a team as a code owner September 4, 2024 19:32
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.84%. Comparing base (e0008ab) to head (3509828).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8752      +/-   ##
==========================================
+ Coverage   60.79%   60.84%   +0.05%     
==========================================
  Files         373      373              
  Lines       38683    38650      -33     
==========================================
  Hits        23516    23516              
+ Misses      15167    15134      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@melanieclarke melanieclarke added this to the Build 11.1 milestone Sep 9, 2024
@melanieclarke
Copy link
Collaborator

Starting regression tests here:
https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1696/

I can't imagine this would impact regtests, but just in case!

Copy link
Collaborator

@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, pending a clean regtest result. Thanks!

@melanieclarke
Copy link
Collaborator

Regtest failures are all unrelated. I will merge when CI is complete.

@melanieclarke melanieclarke merged commit 4dfe982 into spacetelescope:master Sep 10, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants