-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3719: Fix names for intermediate spectral outlier detection files #8735
Conversation
Regression tests here: Failures are all unrelated. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8735 +/- ##
==========================================
+ Coverage 60.34% 60.64% +0.29%
==========================================
Files 372 372
Lines 38374 38371 -3
==========================================
+ Hits 23158 23269 +111
+ Misses 15216 15102 -114 ☔ View full report in Codecov by Sentry. |
Thanks for reviewing @emolter! Since this is a minor technical PR, I'll go ahead and merge when CI completes. |
Resolves JP-3719
Closes #8734
For spectral modes with resampling, intermediate files from outlier detection are not being written correctly. There should be files written to the output directory with suffix 'outlier_s2d'. Instead, there are currently files written to the current directory with suffix 'outlier_i2d', and some duplicate files written to the output directory with suffix 'outlier__outlier_s2d.fits'.
This PR should fix these issues by:
I also added a unit test for spectral outlier detection, along with some checks for these kinds of regressions in intermediate file saving.
Checklist for PR authors (skip items if you don't have permissions or they are not applicable)
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR